Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2756)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)
Patch Set: rebase, address comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
index 23b717ae7e18184e31a7b2cc4ada516502c8836e..53c636819249dc5c00a82ced83dc5360b4756125 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
@@ -40,13 +40,10 @@
private final Set<Integer> mBlacklistedCategories = new HashSet<>();
private final SuggestionsUiDelegate mUiDelegate;
private final OfflinePageBridge mOfflinePageBridge;
- private final SuggestionsRanker mSuggestionsRanker;
public SectionList(SuggestionsUiDelegate uiDelegate, OfflinePageBridge offlinePageBridge) {
- mSuggestionsRanker = new SuggestionsRanker();
mUiDelegate = uiDelegate;
mUiDelegate.getSuggestionsSource().setObserver(this);
- mUiDelegate.getMetricsReporter().setRanker(mSuggestionsRanker);
mOfflinePageBridge = offlinePageBridge;
mUiDelegate.addDestructionObserver(new DestructionObserver() {
@@ -83,7 +80,7 @@ private void resetSections(boolean alwaysAllowEmptySections) {
}
maybeHideArticlesHeader();
- mUiDelegate.getMetricsReporter().onPageShown(categories, suggestionsPerCategory);
+ mUiDelegate.getEventReporter().onPageShown(categories, suggestionsPerCategory);
}
/**
@@ -115,10 +112,11 @@ private int resetSection(@CategoryInt int category, @CategoryStatus int category
// Create the section if needed.
if (section == null) {
+ SuggestionsRanker suggestionsRanker = mUiDelegate.getSuggestionsRanker();
section = new SuggestionsSection(
- this, mUiDelegate, mSuggestionsRanker, mOfflinePageBridge, info);
+ this, mUiDelegate, suggestionsRanker, mOfflinePageBridge, info);
mSections.put(category, section);
- mSuggestionsRanker.registerCategory(category);
+ suggestionsRanker.registerCategory(category);
addChild(section);
} else {
section.clearData();

Powered by Google App Engine
This is Rietveld 408576698