Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2844023002: Ozone DRM: Destroy MusThreadProxy last. (Closed)

Created:
3 years, 8 months ago by kylechar
Modified:
3 years, 8 months ago
Reviewers:
rjkroege
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, James Cook
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ozone DRM: Destroy MusThreadProxy last. A raw pointer MusThreadProxy is held by DrmOverlayManager and DrmDisplayHostManager but MusThreadProxy was being destroyed first. This caused crashes on log out when either of classes tried to access MusThreadProxy in their destructors. Make sure MusThreadProxy is destroyed last. Also fix an issue where DrmDisplayHostManager doesn't unregister itself as a GpuThreadObserver. BUG=714722 Review-Url: https://codereview.chromium.org/2844023002 Cr-Commit-Position: refs/heads/master@{#467430} Committed: https://chromium.googlesource.com/chromium/src/+/28a190c328089bf845181da368f16013108381b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ui/ozone/platform/drm/host/drm_display_host_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/ozone_platform_gbm.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
kylechar
3 years, 8 months ago (2017-04-26 18:14:50 UTC) #2
rjkroege
lgtm
3 years, 8 months ago (2017-04-26 20:07:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844023002/1
3 years, 8 months ago (2017-04-26 20:09:23 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 20:16:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/28a190c328089bf845181da368f1...

Powered by Google App Engine
This is Rietveld 408576698