Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2843993002: VR: Remove unnecessary transparency support from VR compositor. (Closed)

Created:
3 years, 8 months ago by mthiesse
Modified:
3 years, 7 months ago
Reviewers:
cjgrant
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Remove unnecessary transparency support from VR compositor. Just a cleanup patch, no change in functionality. BUG= Review-Url: https://codereview.chromium.org/2843993002 Cr-Commit-Position: refs/heads/master@{#467702} Committed: https://chromium.googlesource.com/chromium/src/+/eacfd594721e0e25ea4d5cd05400618e2938212b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -18 lines) Patch
M chrome/browser/android/vr_shell/vr_compositor.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_compositor.cc View 2 chunks +3 lines, -14 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
mthiesse
PTAL, this code was no longer used after the html UI removal.
3 years, 8 months ago (2017-04-26 16:39:29 UTC) #2
cjgrant
lgtm
3 years, 7 months ago (2017-04-27 15:06:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843993002/1
3 years, 7 months ago (2017-04-27 15:14:36 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 16:20:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eacfd594721e0e25ea4d5cd05400...

Powered by Google App Engine
This is Rietveld 408576698