Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2843963002: Backup and restore data reduction state (Closed)

Created:
3 years, 7 months ago by aberent
Modified:
3 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Backup and restore data reduction state Save the data reduction proxy preferences in backups. Both the Java and the C++ preferences are needed, since the Java pref is used during startup. BUG=705501 Review-Url: https://codereview.chromium.org/2843963002 Cr-Commit-Position: refs/heads/master@{#467624} Committed: https://chromium.googlesource.com/chromium/src/+/07cbcdc2a6293bba57b711d5d449c91a0a0541bc

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java View 2 chunks +3 lines, -2 lines 3 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/android/chrome_backup_agent.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
aberent
https://codereview.chromium.org/2843963002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java (right): https://codereview.chromium.org/2843963002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java#newcode83 chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java:83: FirstRunGlueImpl.CACHED_TOS_ACCEPTED_PREF, FirstRunStatus.FIRST_RUN_FLOW_COMPLETE, Formatting change done by git cl format. ...
3 years, 7 months ago (2017-04-26 13:53:47 UTC) #2
Bernhard Bauer
lgtm https://codereview.chromium.org/2843963002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java (right): https://codereview.chromium.org/2843963002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java#newcode83 chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java:83: FirstRunGlueImpl.CACHED_TOS_ACCEPTED_PREF, FirstRunStatus.FIRST_RUN_FLOW_COMPLETE, On 2017/04/26 13:53:47, aberent wrote: > ...
3 years, 7 months ago (2017-04-27 08:55:17 UTC) #7
aberent
https://codereview.chromium.org/2843963002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java (right): https://codereview.chromium.org/2843963002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java#newcode83 chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java:83: FirstRunGlueImpl.CACHED_TOS_ACCEPTED_PREF, FirstRunStatus.FIRST_RUN_FLOW_COMPLETE, On 2017/04/27 08:55:17, Bernhard Bauer wrote: > ...
3 years, 7 months ago (2017-04-27 09:00:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843963002/1
3 years, 7 months ago (2017-04-27 09:00:38 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 09:04:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/07cbcdc2a6293bba57b711d5d449...

Powered by Google App Engine
This is Rietveld 408576698