Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2843933002: [cleanup] Minor cleanups concerning assemblers and code generation. (Closed)

Created:
3 years, 8 months ago by neis
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Minor cleanups concerning assemblers and code generation. - Use Assembler in a few places that unneccessarily used MacroAssembler before. - Fix some comments. R=jarin@chromium.org BUG=v8:6048 Review-Url: https://codereview.chromium.org/2843933002 Cr-Commit-Position: refs/heads/master@{#44894} Committed: https://chromium.googlesource.com/v8/v8/+/86d2545f77b97b35ec9fe9b24ec80ad9b37bbca5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -28 lines) Patch
M src/assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/macro-assembler.h View 3 chunks +9 lines, -9 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/objects.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
neis
3 years, 8 months ago (2017-04-26 13:08:29 UTC) #1
Jarin
lgtm, thanks!
3 years, 8 months ago (2017-04-26 14:03:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843933002/1
3 years, 8 months ago (2017-04-26 14:04:56 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 14:54:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/86d2545f77b97b35ec9fe9b24ec80ad9b37...

Powered by Google App Engine
This is Rietveld 408576698