Turned the check in callWithIsac16KAndEnsureAudioIsPlaying case-insensitive.

Turned the check in callWithIsac16KAndEnsureAudioIsPlaying case-insensitive.

Payload type names should really be treated case-insensitively. Upcoming changes to WebRTC will completely rework how audio codecs are treated internally. To avoid external breakage, we've had to ensure the case is kept the same as before, for now. Eventually, this will have to change. 

BUG=webrtc:5806
Review-Url: https://codereview.chromium.org/2843923002
Cr-Commit-Position: refs/heads/master@{#472760}
Committed: https://chromium.googlesource.com/chromium/src/+/924fc5cd56d0982004f3ad5163fc00cabf854d48

[ossu-chromium, 2017-04-26 13:02:59]

The CQ bit was checked by ossu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 13:03:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ossu-chromium, 2017-04-26 13:24:56]

Description was changed from

==========
Turned the check in callWithIsac16KAndEnsureAudioIsPlaying case-insensitive.

Changes to WebRTC codec handling have opted to use the case described
in the formats' respective RFCs, which may differ from how we used to
specify them. Also, the payload names really are to be treated without
regard to case.

BUG=webrtc:5806
==========

to

==========
Turned the check in callWithIsac16KAndEnsureAudioIsPlaying case-insensitive.

Payload type names should really be treated case-insensitively. Upcoming changes
to WebRTC will completely rework how audio codecs are treated internally. To
avoid external breakage, we've had to ensure the case is kept the same as
before, for now. Eventually, this will have to change. 

BUG=webrtc:7081
==========

[ossu-chromium, 2017-04-26 13:55:11]

Description was changed from

==========
Turned the check in callWithIsac16KAndEnsureAudioIsPlaying case-insensitive.

Payload type names should really be treated case-insensitively. Upcoming changes
to WebRTC will completely rework how audio codecs are treated internally. To
avoid external breakage, we've had to ensure the case is kept the same as
before, for now. Eventually, this will have to change. 

BUG=webrtc:7081
==========

to

==========
Turned the check in callWithIsac16KAndEnsureAudioIsPlaying case-insensitive.

Payload type names should really be treated case-insensitively. Upcoming changes
to WebRTC will completely rework how audio codecs are treated internally. To
avoid external breakage, we've had to ensure the case is kept the same as
before, for now. Eventually, this will have to change. 

BUG=webrtc:5806
==========

[commit-bot: I haz the power, 2017-04-26 13:56:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 13:56:08]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[ossu-chromium, 2017-04-26 14:19:53]

ossu@chromium.org changed reviewers:
+ ehmaldonado@chromium.org

[ossu-chromium, 2017-04-26 15:26:53]

Patchset #1 (id:1) has been deleted

[ossu-chromium, 2017-04-26 15:27:04]

The CQ bit was checked by ossu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 15:27:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 17:03:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 17:03:03]

Dry run: This issue passed the CQ dry run.

[ossu-chromium, 2017-04-27 08:47:10]

PTAL. This shouldn't block the CL I was working on when hitting this problem,
but it'd be nice if the test were more resilient to future changes.

[ossu-chromium, 2017-05-17 15:14:56]

Friendly ping. I think this one is pretty uncontroversial.
If there's someone else that should review, I can reassign it. The file looks
pretty dormant.

[ehmaldonado_chromium, 2017-05-17 15:20:14]

ehmaldonado@chromium.org changed reviewers:
+ guidou@chromium.org, hbos@chromium.org

[ehmaldonado_chromium, 2017-05-17 15:20:15]

Maybe hbos@ or guidou@ can review this?

[Guido Urdaneta, 2017-05-17 18:27:57]

lgtm

[ossu-chromium, 2017-05-18 09:15:50]

The CQ bit was checked by ossu@chromium.org

[commit-bot: I haz the power, 2017-05-18 09:16:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 10:36:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495098950410160,
"parent_rev": "5f37a9a28cd290fac1dd77efc38b1cc4f848e73a", "commit_rev":
"924fc5cd56d0982004f3ad5163fc00cabf854d48"}

[commit-bot: I haz the power, 2017-05-18 10:36:39]

Description was changed from

==========
Turned the check in callWithIsac16KAndEnsureAudioIsPlaying case-insensitive.

Payload type names should really be treated case-insensitively. Upcoming changes
to WebRTC will completely rework how audio codecs are treated internally. To
avoid external breakage, we've had to ensure the case is kept the same as
before, for now. Eventually, this will have to change. 

BUG=webrtc:5806
==========

to

==========
Turned the check in callWithIsac16KAndEnsureAudioIsPlaying case-insensitive.

Payload type names should really be treated case-insensitively. Upcoming changes
to WebRTC will completely rework how audio codecs are treated internally. To
avoid external breakage, we've had to ensure the case is kept the same as
before, for now. Eventually, this will have to change. 

BUG=webrtc:5806

Review-Url: https://codereview.chromium.org/2843923002
Cr-Commit-Position: refs/heads/master@{#472760}
Committed:
https://chromium.googlesource.com/chromium/src/+/924fc5cd56d0982004f3ad5163fc...
==========

[commit-bot: I haz the power, 2017-05-18 10:36:41]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/924fc5cd56d0982004f3ad5163fc...