Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 2843903002: MD Bookmarks: Add keyboard shortcut support to bookmarks-command-manager (Closed)

Created:
3 years, 8 months ago by tsergeant
Modified:
3 years, 7 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Add keyboard shortcut support to bookmarks-command-manager This adds keyboard shortcuts for Edit, Copy and Delete. BUG=692837 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2843903002 Cr-Commit-Position: refs/heads/master@{#469595} Committed: https://chromium.googlesource.com/chromium/src/+/fad224fbb037adf1a6f37633708732f758f39497

Patch Set 1 #

Patch Set 2 : More tests #

Total comments: 5

Patch Set 3 : Review comments #

Patch Set 4 : Prevent delete when no items are selected #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -1 line) Patch
M chrome/browser/resources/md_bookmarks/command_manager.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/command_manager.js View 1 2 3 3 chunks +33 lines, -1 line 0 comments Download
M chrome/test/data/webui/md_bookmarks/command_manager_test.js View 1 2 3 chunks +67 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (19 generated)
tsergeant
https://codereview.chromium.org/2843903002/diff/40001/chrome/test/data/webui/md_bookmarks/command_manager_test.js File chrome/test/data/webui/md_bookmarks/command_manager_test.js (right): https://codereview.chromium.org/2843903002/diff/40001/chrome/test/data/webui/md_bookmarks/command_manager_test.js#newcode88 chrome/test/data/webui/md_bookmarks/command_manager_test.js:88: test('delete command triggers', function() { I'm not totally convinced ...
3 years, 8 months ago (2017-04-26 08:10:56 UTC) #6
calamity
https://codereview.chromium.org/2843903002/diff/40001/chrome/browser/resources/md_bookmarks/command_manager.js File chrome/browser/resources/md_bookmarks/command_manager.js (right): https://codereview.chromium.org/2843903002/diff/40001/chrome/browser/resources/md_bookmarks/command_manager.js#newcode26 chrome/browser/resources/md_bookmarks/command_manager.js:26: this.shortcuts_ = {}; This isn't declared or annotated anywhere. ...
3 years, 8 months ago (2017-04-26 10:07:59 UTC) #9
tsergeant
🔥 https://codereview.chromium.org/2843903002/diff/40001/chrome/browser/resources/md_bookmarks/command_manager.js File chrome/browser/resources/md_bookmarks/command_manager.js (right): https://codereview.chromium.org/2843903002/diff/40001/chrome/browser/resources/md_bookmarks/command_manager.js#newcode26 chrome/browser/resources/md_bookmarks/command_manager.js:26: this.shortcuts_ = {}; On 2017/04/26 10:07:58, calamity wrote: ...
3 years, 8 months ago (2017-04-27 01:42:51 UTC) #12
calamity
lgtm
3 years, 8 months ago (2017-04-27 03:23:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843903002/100001
3 years, 7 months ago (2017-05-05 04:26:57 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 04:43:31 UTC) #25
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/fad224fbb037adf1a6f376337087...

Powered by Google App Engine
This is Rietveld 408576698