Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 2843833002: refactored TabularContextMenuUi.java (Closed)

Created:
3 years, 8 months ago by injae
Modified:
3 years, 8 months ago
Reviewers:
Daniel Park, gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

refactored TabularContextMenuUi.java moved createPagerView higher up, slight refactoring on logic around displayImageHeader BUG=655359 Review-Url: https://codereview.chromium.org/2843833002 Cr-Commit-Position: refs/heads/master@{#467464} Committed: https://chromium.googlesource.com/chromium/src/+/dda362aee9ed4b1e7d52c1781b2ab31de3e21109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -48 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java View 4 chunks +46 lines, -48 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Daniel Park
3 years, 8 months ago (2017-04-25 22:47:59 UTC) #2
gone
lgtm
3 years, 8 months ago (2017-04-26 16:54:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843833002/1
3 years, 8 months ago (2017-04-26 20:23:01 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 21:29:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dda362aee9ed4b1e7d52c1781b2a...

Powered by Google App Engine
This is Rietveld 408576698