Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2843823003:
Update skia BUILD.gn to add include for vulkan headers (Closed)
DescriptionUpdate skia BUILD.gn to add include for vulkan headers
Since we currently don't support vulkan on chrome, we just add our dummy
Vulkan headers to chromes skia includes so we can the vulkan headers for
type declarations.
BUG=
Review-Url: https://codereview.chromium.org/2843823003
Cr-Commit-Position: refs/heads/master@{#467713}
Committed: https://chromium.googlesource.com/chromium/src/+/e52463bc55e227196e05927253e009dd752a8924
Patch Set 1 #
Messages
Total messages: 24 (12 generated)
egdaniel@chromium.org changed reviewers: + bsalomon@google.com
On 2017/04/26 19:26:00, egdaniel1 wrote: There is a third_party/vulkan/vulkan.h. Perhaps we should use that?
On 2017/04/27 13:18:37, bsalomon wrote: > On 2017/04/26 19:26:00, egdaniel1 wrote: > > There is a third_party/vulkan/vulkan.h. Perhaps we should use that? Sorry, third_party/vulkan/include/vulkan/vulkan.h
lgtm
On 2017/04/27 13:19:12, bsalomon wrote: > On 2017/04/27 13:18:37, bsalomon wrote: > > On 2017/04/26 19:26:00, egdaniel1 wrote: > > > > There is a third_party/vulkan/vulkan.h. Perhaps we should use that? > > Sorry, third_party/vulkan/include/vulkan/vulkan.h That header is really old at this point and I don't think it has everything we need. Should that ever get updated can we switch to using the one on their system.
The CQ bit was checked by egdaniel@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
egdaniel@chromium.org changed reviewers: + robertphillips@chromium.org
robertphillips@google.com changed reviewers: + robertphillips@google.com
lgtm
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by egdaniel@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493311641053380, "parent_rev":
"3ea804c83722800ed63e537836211c07f90a0b1a", "commit_rev":
"e52463bc55e227196e05927253e009dd752a8924"}
Message was sent while issue was closed.
Description was changed from ========== Update skia BUILD.gn to add include for vulkan headers Since we currently don't support vulkan on chrome, we just add our dummy Vulkan headers to chromes skia includes so we can the vulkan headers for type declarations. BUG= ========== to ========== Update skia BUILD.gn to add include for vulkan headers Since we currently don't support vulkan on chrome, we just add our dummy Vulkan headers to chromes skia includes so we can the vulkan headers for type declarations. BUG= Review-Url: https://codereview.chromium.org/2843823003 Cr-Commit-Position: refs/heads/master@{#467713} Committed: https://chromium.googlesource.com/chromium/src/+/e52463bc55e227196e05927253e0... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e52463bc55e227196e05927253e0... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
