Suppress limits_gl_max_texture_dimensions on P400.

Suppress limits_gl_max_texture_dimensions on P400.

Supress WebglConformance_conformance_limits_gl_max_texture_dimensions
on nVidia Quadro P400 cards on Linux and Win10.

BUG=715001
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2843803002
Cr-Commit-Position: refs/heads/master@{#467201}
Committed: https://chromium.googlesource.com/chromium/src/+/de2639a09ee8be98b746c6785d83bb57ee6fa9c2

[fjhenigman, 2017-04-25 19:47:43]

Description was changed from

==========
Suppress limits_gl_max_texture_dimensions on P400.

Supress WebglConformance_conformance_limits_gl_max_texture_dimensions
on nVidia Quadro P400 cards on Linux and Win10.

BUG=715001
==========

to

==========
Suppress limits_gl_max_texture_dimensions on P400.

Supress WebglConformance_conformance_limits_gl_max_texture_dimensions
on nVidia Quadro P400 cards on Linux and Win10.

BUG=715001
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[fjhenigman, 2017-04-25 19:48:17]

Description was changed from

==========
Suppress limits_gl_max_texture_dimensions on P400.

Supress WebglConformance_conformance_limits_gl_max_texture_dimensions
on nVidia Quadro P400 cards on Linux and Win10.

BUG=715001
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Suppress limits_gl_max_texture_dimensions on P400.

Supress WebglConformance_conformance_limits_gl_max_texture_dimensions
on nVidia Quadro P400 cards on Linux and Win10.

BUG=715001
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[fjhenigman, 2017-04-25 19:48:17]

fjhenigman@chromium.org changed reviewers:
+ kbr@chromium.org, ynovikov@chromium.org

[fjhenigman, 2017-04-25 19:49:39]

Reviewers please look carefully.  I've not done one of these lately (or ever?)
so there's a better than usual chance I messed up.

[ynovikov, 2017-04-25 20:52:36]

On 2017/04/25 19:49:39, fjhenigman wrote:
> Reviewers please look carefully.  I've not done one of these lately (or ever?)
> so there's a better than usual chance I messed up.

I think you could be more restrictive.
On Linux it fails in webgl_conformance_angle_tests and
webgl_conformance_gl_passthrough_tests, so I think you could add 'opengl' to
conditions.
On Windows it fails in webgl_conformance_gl_tests, so I think add 'opengl' as
well.
Otherwise, lgtm

[ynovikov, 2017-04-25 20:53:23]

On 2017/04/25 20:52:36, ynovikov wrote:
> On 2017/04/25 19:49:39, fjhenigman wrote:
> > Reviewers please look carefully.  I've not done one of these lately (or
ever?)
> > so there's a better than usual chance I messed up.
> 
> I think you could be more restrictive.
> On Linux it fails in webgl_conformance_angle_tests and
> webgl_conformance_gl_passthrough_tests, so I think you could add 'opengl' to
> conditions.
> On Windows it fails in webgl_conformance_gl_tests, so I think add 'opengl' as
> well.
> Otherwise, lgtm

Maybe also mention ANGLE OpenGL backend in Description.

[Ken Russell (switch to Gerrit), 2017-04-26 00:51:26]

Agree with Yuly's assessment, but let's land this now. Please follow up with
more targeted suppressions. lgtm

[Ken Russell (switch to Gerrit), 2017-04-26 00:51:29]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:52:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 02:03:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493167889484140, "parent_rev":
"e612058238bb3f549a917d55f94badf32377f85c", "commit_rev":
"de2639a09ee8be98b746c6785d83bb57ee6fa9c2"}

[commit-bot: I haz the power, 2017-04-26 02:03:27]

Description was changed from

==========
Suppress limits_gl_max_texture_dimensions on P400.

Supress WebglConformance_conformance_limits_gl_max_texture_dimensions
on nVidia Quadro P400 cards on Linux and Win10.

BUG=715001
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Suppress limits_gl_max_texture_dimensions on P400.

Supress WebglConformance_conformance_limits_gl_max_texture_dimensions
on nVidia Quadro P400 cards on Linux and Win10.

BUG=715001
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2843803002
Cr-Commit-Position: refs/heads/master@{#467201}
Committed:
https://chromium.googlesource.com/chromium/src/+/de2639a09ee8be98b746c6785d83...
==========

[commit-bot: I haz the power, 2017-04-26 02:03:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/de2639a09ee8be98b746c6785d83...