Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 2843783003: Expose Value::GetList and Value(ListStorage) on ListValue (Closed)

Created:
3 years, 8 months ago by jdoerrie
Modified:
3 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose Value::GetList and Value(ListStorage) on ListValue This change exposes the API introduced in r465517 also on the ListValue class directly. This is for convenience, as it simplifies deprecating the old raw pointer based APIs which eventually will lead to the complete inlining of the ListValue class into Value. R=brettw@chromium.org BUG=646113 Review-Url: https://codereview.chromium.org/2843783003 Cr-Commit-Position: refs/heads/master@{#467384} Committed: https://chromium.googlesource.com/chromium/src/+/52939ed422f481e2970edfa57a8bf24ca3dbacb8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M base/values.h View 2 chunks +4 lines, -0 lines 0 comments Download
M base/values.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M base/values_unittest.cc View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
jdoerrie
Hi Brett, please take a look. This change should only have a temporary impact, but ...
3 years, 8 months ago (2017-04-26 11:37:30 UTC) #5
brettw
lgtm
3 years, 8 months ago (2017-04-26 17:59:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843783003/1
3 years, 8 months ago (2017-04-26 18:14:17 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 18:20:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/52939ed422f481e2970edfa57a8b...

Powered by Google App Engine
This is Rietveld 408576698