Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2843773003: Add a GN flag to allow sanitizer builds with full debugging symbols. (Closed)

Created:
3 years, 7 months ago by Oliver Chang
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, tnn, mstensho (USE GERRIT)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a GN flag to allow sanitizer builds with full debugging symbols. R=thakis@chromium.org BUG=692620 Review-Url: https://codereview.chromium.org/2843773003 Cr-Commit-Position: refs/heads/master@{#467178} Committed: https://chromium.googlesource.com/chromium/src/+/2a7ed44b0ffb4f4e8f70dd5c0c82ad0046d84964

Patch Set 1 #

Patch Set 2 : rename flag #

Patch Set 3 : rename flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M build/config/sanitizers/BUILD.gn View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M build/config/sanitizers/sanitizers.gni View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Oliver Chang
PTAL
3 years, 7 months ago (2017-04-25 22:47:59 UTC) #5
Nico
Is this really something people use frequently? For one-offs, one can just uncomment that line ...
3 years, 7 months ago (2017-04-25 22:50:34 UTC) #6
Oliver Chang
On 2017/04/25 22:50:34, Nico wrote: > Is this really something people use frequently? For one-offs, ...
3 years, 7 months ago (2017-04-25 23:01:44 UTC) #7
Nico
sanitizer_keep_symbols? On Tue, Apr 25, 2017 at 7:01 PM, <ochang@chromium.org> wrote: > On 2017/04/25 22:50:34, ...
3 years, 7 months ago (2017-04-25 23:02:45 UTC) #8
Oliver Chang
On 2017/04/25 23:02:45, Nico wrote: > sanitizer_keep_symbols? Thanks, renamed! > > On Tue, Apr 25, ...
3 years, 7 months ago (2017-04-25 23:12:38 UTC) #9
Nico
lgtm :-/
3 years, 7 months ago (2017-04-25 23:15:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843773003/40001
3 years, 7 months ago (2017-04-25 23:18:16 UTC) #12
Oliver Chang
On 2017/04/25 23:15:12, Nico wrote: > lgtm :-/ thanks, why the ":-/" ? :-/
3 years, 7 months ago (2017-04-25 23:21:06 UTC) #13
Nico
On Tue, Apr 25, 2017 at 7:21 PM, <ochang@chromium.org> wrote: > On 2017/04/25 23:15:12, Nico ...
3 years, 7 months ago (2017-04-25 23:24:27 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 00:23:46 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2a7ed44b0ffb4f4e8f70dd5c0c82...

Powered by Google App Engine
This is Rietveld 408576698