Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2843763005: Clear hash when setting URL in document.open() (Closed)

Created:
3 years, 8 months ago by bokan
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Clear hash when setting URL in document.open() A document created via document.open()/write()/close() will have as its URL the "responsible document" (see step #23 of https://html.spec.whatwg.org/multipage/webappapis.html#dom-document-open) This is a problem when the URL includes a fragment identifier, any frame with a document.open from a document with a fragment will try to scroll the iframe into view. I believe the intent in the spec was not to include the hash. BUG=699267 Review-Url: https://codereview.chromium.org/2801093002 Cr-Commit-Position: refs/heads/master@{#466770} (cherry picked from commit 783d491b68d1b5833b65accba2e4fd595f09a404) Review-Url: https://codereview.chromium.org/2843763005 . Cr-Commit-Position: refs/branch-heads/3071@{#232} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/6c3f14d345e3a04319074eced38eec423b8cd537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/scrolling/doc-write-to-iframe.html View 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
bokan
3 years, 8 months ago (2017-04-26 18:15:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c3f14d345e3a04319074eced38eec423b8cd537.

Powered by Google App Engine
This is Rietveld 408576698