Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2843763003: Fix MSE garbage collection for disabled media tracks (Closed)

Created:
3 years, 8 months ago by servolk
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fix MSE garbage collection for disabled media tracks Renderers don't read from disabled demuxer streams, thus leaving demuxer stream read position unchanged. But MSE garbage collection currently stops removing data from the front of buffered ranges when it reaches the last read position. This results in QuotaExceeded exceptions being thrown when more data is appended to the disabled stream. The fix is to seek the disabled stream before running MSE GC, this will update the read position to the current media_time and should allow the GC algorithm to remove data as expected. BUG=713423 Review-Url: https://codereview.chromium.org/2827983004 Cr-Commit-Position: refs/heads/master@{#466136} (cherry picked from commit ac9a37e939ced07b8d5f4f74f4829013895f0cf4) Review-Url: https://codereview.chromium.org/2843763003 . Cr-Commit-Position: refs/branch-heads/3071@{#212} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/515105ff4145383c24b800e29a7faa845028f883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -14 lines) Patch
M media/filters/chunk_demuxer.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/chunk_demuxer.cc View 2 chunks +18 lines, -9 lines 0 comments Download
M media/filters/source_buffer_state.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/source_buffer_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/test/pipeline_integration_test.cc View 2 chunks +33 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
servolk
3 years, 8 months ago (2017-04-25 23:50:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
515105ff4145383c24b800e29a7faa845028f883.

Powered by Google App Engine
This is Rietveld 408576698