Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2843703002: Merge of "Add DownloadStatus metric to FaviconHandler" into M59 (Closed)

Created:
3 years, 8 months ago by fhorschig
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge of "Add DownloadStatus metric to FaviconHandler" into M59 This is a merge of https://codereview.chromium.org/2808063002/ into M59. Reason: recording metrics in M59 (and not waiting for M60). === Original description === Add DownloadStatus metric to FaviconHandler This metric records how often single icon downloads fail with 404 and how often 404'ing icons can be skipped because they were already known. BUG=694956 Review-Url: https://codereview.chromium.org/2808063002 Cr-Commit-Position: refs/heads/master@{#465545} (cherry picked from commit be0a6071e24bc1e0f432533042d3d813bbe6ed3f) Review-Url: https://codereview.chromium.org/2843703002 . Cr-Commit-Position: refs/branch-heads/3071@{#193} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/a35ca902cc2840eaaab3715060a4a17f91d486c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -0 lines) Patch
M components/favicon/core/favicon_handler.h View 1 chunk +13 lines, -0 lines 0 comments Download
M components/favicon/core/favicon_handler.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M components/favicon/core/favicon_handler_unittest.cc View 5 chunks +44 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
fhorschig
3 years, 8 months ago (2017-04-25 07:50:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a35ca902cc2840eaaab3715060a4a17f91d486c8.

Powered by Google App Engine
This is Rietveld 408576698