Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2843663002: Fix analyze in mb.py. (Closed)

Created:
3 years, 8 months ago by Dirk Pranke
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix analyze in mb.py. As part of #466704, I changed some logic in mb.py to sort the inputs that MB hands to GN, in an attempt to make the debugging output a little easier to follow. It turns out that the way I did this was broken, as there was a dependency on the ordering of the unsorted values. As a result, MB started remapping GN's analyze results back to the wrong targets, and we've been running the wrong test steps since #466704 landed :(. TBR=kbr@chromium.org, jam@chromium.org BUG=714336 NOTRY=true Review-Url: https://codereview.chromium.org/2843663002 Cr-Commit-Position: refs/heads/master@{#466828} Committed: https://chromium.googlesource.com/chromium/src/+/b7b183fa716d3b18f69ebc18e290eb97d735f296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M tools/mb/mb.py View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Dirk Pranke
3 years, 8 months ago (2017-04-24 23:46:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843663002/1
3 years, 8 months ago (2017-04-24 23:46:46 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 23:50:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b7b183fa716d3b18f69ebc18e290...

Powered by Google App Engine
This is Rietveld 408576698