ash: Return empty shelf icon bounds before initialization.

ash: Return empty shelf icon bounds before initialization.

Bail GetIdealBoundsOfItemIcon before |last_visible_index_| init.
(avoid using button bounds before they are calculated)

This is a simple workaround for a failing clusterfuzz check.
The test case is not reproducible, and unlikely to be hit manually.
There's little reason to seek a more comprehensive fix for now.

TODO: Merge AppListButton and ShelfButton (or use inheritance).

BUG=707165
TEST=No failed button CHECK via clusterfuzz. (Not reproducible)
R=xiyuan@chromium.org

Review-Url: https://codereview.chromium.org/2843623002
Cr-Commit-Position: refs/heads/master@{#466776}
Committed: https://chromium.googlesource.com/chromium/src/+/5638001af068337b354a2d43d65b25ae3638ace2

[msw, 2017-04-24 20:19:59]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 20:20:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 20:48:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 20:48:05]

Dry run: This issue passed the CQ dry run.

[msw, 2017-04-24 20:50:15]

Hey Xiyuan, please take a look; thanks!

[xiyuan, 2017-04-24 21:22:02]

lgtm

[msw, 2017-04-24 21:30:14]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2017-04-24 21:31:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 21:36:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493069414573840, "parent_rev":
"26235f6667581ffce3c742644563fb41a1d08383", "commit_rev":
"5638001af068337b354a2d43d65b25ae3638ace2"}

[commit-bot: I haz the power, 2017-04-24 21:36:56]

Description was changed from

==========
ash: Return empty shelf icon bounds before initialization.

Bail GetIdealBoundsOfItemIcon before |last_visible_index_| init.
(avoid using button bounds before they are calculated)

This is a simple workaround for a failing clusterfuzz check.
The test case is not reproducible, and unlikely to be hit manually.
There's little reason to seek a more comprehensive fix for now.

TODO: Merge AppListButton and ShelfButton (or use inheritance).

BUG=707165
TEST=No failed button CHECK via clusterfuzz. (Not reproducible)
R=xiyuan@chromium.org
==========

to

==========
ash: Return empty shelf icon bounds before initialization.

Bail GetIdealBoundsOfItemIcon before |last_visible_index_| init.
(avoid using button bounds before they are calculated)

This is a simple workaround for a failing clusterfuzz check.
The test case is not reproducible, and unlikely to be hit manually.
There's little reason to seek a more comprehensive fix for now.

TODO: Merge AppListButton and ShelfButton (or use inheritance).

BUG=707165
TEST=No failed button CHECK via clusterfuzz. (Not reproducible)
R=xiyuan@chromium.org

Review-Url: https://codereview.chromium.org/2843623002
Cr-Commit-Position: refs/heads/master@{#466776}
Committed:
https://chromium.googlesource.com/chromium/src/+/5638001af068337b354a2d43d65b...
==========

[commit-bot: I haz the power, 2017-04-24 21:36:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5638001af068337b354a2d43d65b...