Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 2843513005: Fix uninitialized pointer in unit tests. (Closed)

Created:
3 years, 8 months ago by Pete Williamson
Modified:
3 years, 8 months ago
Reviewers:
romax
CC:
chromium-reviews, cbentzel+watch_chromium.org, dewittj+watch_chromium.org, tburkard+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, gavinp+prer_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix uninitialized pointer in unit tests. This may be causing the flakiness we have been seeing with prerendering offliner unit tests. BUG=712941 Review-Url: https://codereview.chromium.org/2843513005 Cr-Commit-Position: refs/heads/master@{#467081} Committed: https://chromium.googlesource.com/chromium/src/+/b16ffdebce9e4724eb3e415c8760abc751d1c035

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Pete Williamson
3 years, 8 months ago (2017-04-25 18:24:45 UTC) #2
romax
i guess in order to use dry-run to see if this fixes flakiness, we should ...
3 years, 8 months ago (2017-04-25 18:47:38 UTC) #5
Pete Williamson
On 2017/04/25 18:47:38, romax wrote: > i guess in order to use dry-run to see ...
3 years, 8 months ago (2017-04-25 19:29:15 UTC) #8
romax
lgtm
3 years, 8 months ago (2017-04-25 19:55:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843513005/1
3 years, 8 months ago (2017-04-25 19:58:11 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 20:03:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b16ffdebce9e4724eb3e415c8760...

Powered by Google App Engine
This is Rietveld 408576698