Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2843513004: [Payments] Return basic-card as the method name when possible. (Closed)

Created:
3 years, 8 months ago by Mathieu
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, darin-cc_chromium.org, mahmadi+paymentswatch_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Return basic-card as the method name when possible. If the merchant specified a supported network through basic-card, prefer to return "basic-card" as the method name in the Payment Response, regardless of whether the same network was specified in supportedMethods. BUG=714948 TEST=components_unittests Review-Url: https://codereview.chromium.org/2843513004 Cr-Commit-Position: refs/heads/master@{#466988} Committed: https://chromium.googlesource.com/chromium/src/+/1673bae1b589cb2ab998b5206bc657ccf1b9877f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M components/payments/content/payment_request_spec_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/payments/core/payment_request_data_util.cc View 2 chunks +23 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Mathieu
Rouslan, PTAL?
3 years, 8 months ago (2017-04-25 12:01:08 UTC) #6
please use gerrit instead
lgtm
3 years, 8 months ago (2017-04-25 14:33:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843513004/1
3 years, 8 months ago (2017-04-25 14:39:42 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 14:43:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1673bae1b589cb2ab998b5206bc6...

Powered by Google App Engine
This is Rietveld 408576698