Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2843503002: scheduler: Move WebFrameScheduler and WebScheduler into Blink (Closed)

Created:
3 years, 8 months ago by Sami
Modified:
3 years, 8 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, tzik, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, serviceworker-reviews, leviw+renderwatch, shans, kinuko+worker_chromium.org, kinuko+watch, rwlbuis, jsbell+serviceworker_chromium.org, Yoav Weiss, krit, drott+blinkwatch_chromium.org, Mads Ager (chromium), yhirano+watch_chromium.org, blink-reviews-html_chromium.org, jam, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, darin-cc_chromium.org, gavinp+loader_chromium.org, jchaffraix+rendering, blink-reviews, blink-reviews-bindings_chromium.org, falken+watch_chromium.org, mac-reviews_chromium.org, ajuma+watch_chromium.org, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, Eric Willigers, panicker+watch_chromium.org, mlamouri+watch-content_chromium.org, rjwright, blink-reviews-style_chromium.org, zoltan1, blink-reviews-layout_chromium.org, sof, nhiroki, loading-reviews_chromium.org, pdr+graphicswatchlist_chromium.org, darktears, loading-reviews+fetch_chromium.org, Nate Chapin, Stephen Chennney, michaeln, shimazu+serviceworker_chromium.org, tyoshino+watch_chromium.org, ajuma+watch-canvas_chromium.org, kouhei+heap_chromium.org, pdr+renderingwatchlist_chromium.org, loading-reviews+parser_chromium.org, fmalita+watch_chromium.org, shimazu+worker_chromium.org, blink-layers+watch_chromium.org, kinuko+serviceworker, blink-reviews-animation_chromium.org, oilpan-reviews, horo+watch_chromium.org, blink-reviews-frames_chromium.org, scheduler-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Move WebFrameScheduler and WebScheduler into Blink Move WebFrameScheduler and WebScheduler into Blink since there is no need to expose these classes to outside components. No functional changes. BUG=696001, 701223 TBR=jochen@chromium.org,dalecurtis@chromium.org Review-Url: https://codereview.chromium.org/2843503002 Cr-Commit-Position: refs/heads/master@{#467058} Committed: https://chromium.googlesource.com/chromium/src/+/d80c41e37b7570607f6f877961f487f7f24ae12e

Patch Set 1 #

Patch Set 2 : Build fix #

Patch Set 3 : Rebased #

Patch Set 4 : Build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -308 lines) Patch
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/run_all_unittests.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8IdleTaskRunner.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IdleDeadline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IdleDeadlineTest.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PresentationAttributeStyle.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/page/ScopedPageSuspender.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/WorkerPerformance.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/WebSocketHandleImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Timer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/TimerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/WebScheduler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/RawResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/Resource.cpp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/scheduler/child/web_scheduler.h View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/test/fake_renderer_scheduler.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTestSuite.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ActiveConnectionThrottlingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/VirtualTimeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/public/platform/WebScheduler.h View 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/WebKit/public/platform/WebViewScheduler.h View 1 chunk +0 lines, -92 lines 0 comments Download
M third_party/WebKit/public/platform/scheduler/renderer/renderer_scheduler.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/scheduler/test/fake_renderer_scheduler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/scheduler/test/mock_renderer_scheduler.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 33 (25 generated)
Sami
PTAL.
3 years, 8 months ago (2017-04-24 15:45:09 UTC) #4
haraken
LGTM. Sorry about the review delay. Our plan is to remove WebScheduler, right? What about ...
3 years, 8 months ago (2017-04-25 17:45:39 UTC) #20
Sami
On 2017/04/25 17:45:39, haraken wrote: > LGTM. Sorry about the review delay. Thanks, no problem! ...
3 years, 8 months ago (2017-04-25 18:10:44 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843503002/50001
3 years, 8 months ago (2017-04-25 18:11:31 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/419887)
3 years, 8 months ago (2017-04-25 18:22:54 UTC) #25
Sami
TBR'ing content/ and media/ owners since the changes are trivial.
3 years, 8 months ago (2017-04-25 18:28:01 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843503002/50001
3 years, 8 months ago (2017-04-25 18:28:56 UTC) #30
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 18:35:54 UTC) #33
Message was sent while issue was closed.
Committed patchset #4 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/d80c41e37b7570607f6f877961f4...

Powered by Google App Engine
This is Rietveld 408576698