Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2843463003: Fix a compilation error with 10.11 SDK. (Closed)

Created:
3 years, 8 months ago by erikchen
Modified:
3 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, danakj+watch_chromium.org, mac-reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a compilation error with 10.11 SDK. TASK_VM_INFO_REV1_COUNT is defined in the 10.12 SDK, but has a different name in the 10.11 SDK (TASK_VM_INFO_COUNT). Instead of using it, just use sizeof(ChromeTaskVMInfo) / sizeof(natural_t), which works for all SDK versions. BUG=713854 Review-Url: https://codereview.chromium.org/2843463003 Cr-Commit-Position: refs/heads/master@{#466689} Committed: https://chromium.googlesource.com/chromium/src/+/3858a3320d4c95db2662b8e1b6e34c3bda979135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M base/process/process_metrics_mac.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
erikchen
mark: Please review.
3 years, 8 months ago (2017-04-24 17:38:27 UTC) #3
Mark Mentovai
LGTM
3 years, 8 months ago (2017-04-24 17:38:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843463003/1
3 years, 8 months ago (2017-04-24 17:40:41 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 18:16:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3858a3320d4c95db2662b8e1b6e3...

Powered by Google App Engine
This is Rietveld 408576698