Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1845)

Issue 2843433005: Revert of chromeos: Add CPU temperature reader (Closed)

Created:
3 years, 8 months ago by yhirano
Modified:
3 years, 8 months ago
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of chromeos: Add CPU temperature reader (patchset #11 id:220001 of https://codereview.chromium.org/2823583002/ ) Reason for revert: This change causes a build error. Original issue's description: > chromeos: Add CPU temperature reader > > Reads from hwmon in sysfs. > > This does the same thing as ReadCPUTempInfo() in > chrome/browser/chromeos/policy/device_status_collector.cc, but it is > available to the rest of Chrome. > > BUG=chromium:709102 > > Review-Url: https://codereview.chromium.org/2823583002 > Cr-Commit-Position: refs/heads/master@{#466858} > Committed: https://chromium.googlesource.com/chromium/src/+/745fad9fe0f68a795a191a32cb038d864bfc2dbf TBR=derat@chromium.org,stevenjb@chromium.org,sque@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:709102 Review-Url: https://codereview.chromium.org/2843433005 Cr-Commit-Position: refs/heads/master@{#466874} Committed: https://chromium.googlesource.com/chromium/src/+/2ec8db556b910043043526d09c46e00ef691a9d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -316 lines) Patch
M chromeos/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D chromeos/system/cpu_temperature_reader.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chromeos/system/cpu_temperature_reader.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D chromeos/system/cpu_temperature_reader_unittest.cc View 1 chunk +0 lines, -136 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
yhirano
Created Revert of chromeos: Add CPU temperature reader
3 years, 8 months ago (2017-04-25 05:04:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843433005/1
3 years, 8 months ago (2017-04-25 05:04:44 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 05:06:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ec8db556b910043043526d09c46...

Powered by Google App Engine
This is Rietveld 408576698