Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 2843433004: Remove WebInputMethodControllerImpl::suppress_next_keypress_event_ (Closed)

Created:
3 years, 8 months ago by rlanday
Modified:
3 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebInputMethodControllerImpl::suppress_next_keypress_event_ I was working on maybe adding something to this file and noticed that this flag is always initialized to false and the setter is never used. So I think it can be removed. BUG= Review-Url: https://codereview.chromium.org/2843433004 Cr-Commit-Position: refs/heads/master@{#466893} Committed: https://chromium.googlesource.com/chromium/src/+/ff8c6a8ed47918813193703405f0161ffe3247a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M third_party/WebKit/Source/web/WebInputMethodControllerImpl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
rlanday
3 years, 8 months ago (2017-04-24 23:27:41 UTC) #3
tkent
lgtm
3 years, 8 months ago (2017-04-25 03:07:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843433004/1
3 years, 8 months ago (2017-04-25 03:08:30 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 05:32:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ff8c6a8ed47918813193703405f0...

Powered by Google App Engine
This is Rietveld 408576698