Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2843413002: Update Mus IME mojom and struct traits with new style enums and tests. (Closed)

Created:
3 years, 7 months ago by Hadi
Modified:
3 years, 7 months ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Mus IME mojom and struct traits with new style enums and tests. * Use kFoo for enums. * Don't need to use mojom to test serialization of structs. BUG=NONE Review-Url: https://codereview.chromium.org/2843413002 Cr-Commit-Position: refs/heads/master@{#467712} Committed: https://chromium.googlesource.com/chromium/src/+/3ea804c83722800ed63e537836211c07f90a0b1a

Patch Set 1 #

Patch Set 2 : cleanup. #

Patch Set 3 : Check for deserialization success. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -101 lines) Patch
M services/ui/public/interfaces/ime/ime.mojom View 1 2 3 1 chunk +30 lines, -30 lines 0 comments Download
M services/ui/public/interfaces/ime/ime_struct_traits.cc View 1 2 3 4 chunks +62 lines, -62 lines 0 comments Download
M services/ui/public/interfaces/ime/ime_struct_traits_test.mojom View 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/public/interfaces/ime/ime_struct_traits_unittest.cc View 1 2 3 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
Hadi
PTAL. Deserialize(Serialize()) didn't work for enums, so I kept EchoTextInputType() and EchoTextInputMode(), but removed EchoCompositionText().
3 years, 7 months ago (2017-04-27 13:13:01 UTC) #6
sky
LGTM
3 years, 7 months ago (2017-04-27 15:25:34 UTC) #11
Tom Sepez
RS LGTM
3 years, 7 months ago (2017-04-27 16:11:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843413002/60001
3 years, 7 months ago (2017-04-27 16:44:38 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 16:54:34 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3ea804c83722800ed63e53783621...

Powered by Google App Engine
This is Rietveld 408576698