CrOS: Right align captive portal/"controlled by extension" network icon

CrOS: Right align captive portal/"controlled by extension" network icon

BUG=690179
Review-Url: https://codereview.chromium.org/2843383004
Cr-Commit-Position: refs/heads/master@{#468474}
Committed: https://chromium.googlesource.com/chromium/src/+/3529f6950ab71263ac77d1d6cc64158a9bd1b2e2

[Evan Stade, 2017-04-27 21:44:51]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:45:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-04-27 21:45:24]

estade@chromium.org changed reviewers:
+ tdanderson@chromium.org

[Evan Stade, 2017-04-27 21:45:25]

screenshot on bug. Seems a little off to me but we'll see what Sebastien says.

[commit-bot: I haz the power, 2017-04-28 01:36:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 01:36:57]

Dry run: This issue passed the CQ dry run.

[tdanderson, 2017-04-28 17:33:53]

PS1 lgtm provided there is signoff on the layout

[Evan Stade, 2017-04-28 21:48:08]

layout issue addressed, ptal

[Evan Stade, 2017-04-29 13:45:55]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 13:46:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 13:48:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 13:48:33]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tdanderson, 2017-05-01 15:31:16]

https://codereview.chromium.org/2843383004/diff/20001/ash/system/network/netw...
File ash/system/network/network_state_list_detailed_view.cc (left):

https://codereview.chromium.org/2843383004/diff/20001/ash/system/network/netw...
ash/system/network/network_state_list_detailed_view.cc:466: new
FixedSizedImageView(kTrayPopupDetailsIconWidth, 0);
Can you please rebase and then re-ping? It looks like the code you're modifying
currently lives in network_list.cc and not network_state_list_detailed_view.cc

[Evan Stade, 2017-05-01 17:57:45]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-05-01 17:57:53]

On 2017/05/01 15:31:16, tdanderson wrote:
>
https://codereview.chromium.org/2843383004/diff/20001/ash/system/network/netw...
> File ash/system/network/network_state_list_detailed_view.cc (left):
> 
>
https://codereview.chromium.org/2843383004/diff/20001/ash/system/network/netw...
> ash/system/network/network_state_list_detailed_view.cc:466: new
> FixedSizedImageView(kTrayPopupDetailsIconWidth, 0);
> Can you please rebase and then re-ping? It looks like the code you're
modifying
> currently lives in network_list.cc and not network_state_list_detailed_view.cc

rebased

[commit-bot: I haz the power, 2017-05-01 17:58:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 18:38:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 18:38:35]

Dry run: This issue passed the CQ dry run.

[tdanderson, 2017-05-01 20:04:05]

PS4 lgtm

[Evan Stade, 2017-05-01 23:04:23]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-05-01 23:05:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 23:11:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493679863878920,
"parent_rev": "79b60e688e852d5613913610c349eaf075601853", "commit_rev":
"3529f6950ab71263ac77d1d6cc64158a9bd1b2e2"}

[commit-bot: I haz the power, 2017-05-01 23:11:52]

Description was changed from

==========
CrOS: Right align captive portal/"controlled by extension" network icon

BUG=690179
==========

to

==========
CrOS: Right align captive portal/"controlled by extension" network icon

BUG=690179

Review-Url: https://codereview.chromium.org/2843383004
Cr-Commit-Position: refs/heads/master@{#468474}
Committed:
https://chromium.googlesource.com/chromium/src/+/3529f6950ab71263ac77d1d6cc64...
==========

[commit-bot: I haz the power, 2017-05-01 23:11:56]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3529f6950ab71263ac77d1d6cc64...