Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: device/wake_lock/public/interfaces/wake_lock_service.mojom

Issue 2843353003: Move ownership of PowerSaveBlocker from WakeLockServiceContext to WakeLockServiceImpl (Closed)
Patch Set: error fix, non-frame client. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/wake_lock/public/interfaces/wake_lock_service.mojom
diff --git a/device/wake_lock/public/interfaces/wake_lock_service.mojom b/device/wake_lock/public/interfaces/wake_lock_service.mojom
index 8c6e7a494c0f32fd97537713ab2222585860d65f..d5a8c123e84ac0a9e09d3956c8139cb4bd261994 100644
--- a/device/wake_lock/public/interfaces/wake_lock_service.mojom
+++ b/device/wake_lock/public/interfaces/wake_lock_service.mojom
@@ -8,4 +8,10 @@ module device.mojom;
interface WakeLockService {
RequestWakeLock();
CancelWakeLock();
+
+ // TODO(heke): The AddClient() interface is only used by WebContents for the
blundell 2017/05/02 11:27:43 Actually, I think it's fine to leave this method o
ke.he 2017/05/04 11:54:14 Yes, Totally understand after the mail discussion.
+ // purpose of coalescing requests from frames. It is better to split it into
+ // a seperate mojo interface and refactor WakeLockServiceContext and
+ // WakeLockServiceImpl accordingly.
+ AddClient(WakeLockService& wake_lock);
};

Powered by Google App Engine
This is Rietveld 408576698