device/wake_lock/public/interfaces/wake_lock_service.mojom - Issue 2843353003: Move ownership of PowerSaveBlocker from WakeLockServiceContext to WakeLockServiceImpl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/wake_lock/public/interfaces/wake_lock_service.mojom

Issue 2843353003: Move ownership of PowerSaveBlocker from WakeLockServiceContext to WakeLockServiceImpl (Closed)

Patch Set: error fix, non-frame client. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/public/browser/web_contents.h ('K') | « device/wake_lock/public/interfaces/wake_lock_param_traits.cc ('k') | device/wake_lock/wake_lock_context_provider.h » ('j') | device/wake_lock/wake_lock_service_context.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module device.mojom;	5 module device.mojom;

6	6

7 // WebLockService receives wake lock preferences from its client.	7 // WebLockService receives wake lock preferences from its client.

8 interface WakeLockService {	8 interface WakeLockService {

9 RequestWakeLock();	9 RequestWakeLock();

10 CancelWakeLock();	10 CancelWakeLock();

	11

	12 // TODO(heke): The AddClient() interface is only used by WebContents for the
	blundell 2017/05/02 11:27:43 Actually, I think it's fine to leave this method o Actually, I think it's fine to leave this method on this interface. There is a use case for coalescing requests from multiple clients. In the future, maybe there will be clients other than Blink for that use case. ke.he 2017/05/04 11:54:14 Yes, Totally understand after the mail discussion. Show quoted text On 2017/05/02 11:27:43, blundell wrote: > Actually, I think it's fine to leave this method on this interface. There is a > use case for coalescing requests from multiple clients. In the future, maybe > there will be clients other than Blink for that use case. Yes, Totally understand after the mail discussion.
	13 // purpose of coalescing requests from frames. It is better to split it into

	14 // a seperate mojo interface and refactor WakeLockServiceContext and

	15 // WakeLockServiceImpl accordingly.

	16 AddClient(WakeLockService& wake_lock);

11 };	17 };

OLD	NEW