Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2843353002: [serializer] correctly output statistics. (Closed)

Created:
3 years, 7 months ago by Yang
Modified:
3 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] correctly output statistics. kNumberOfSpaces includes map and large object spaces, kNumberOfPreallocatedSpaces does not. Therefore we need to output both separately. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2843353002 Cr-Commit-Position: refs/heads/master@{#44912} Committed: https://chromium.googlesource.com/v8/v8/+/b5de6719da0a9f486ee950dbf68301eaab679347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/snapshot/serializer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Yang
3 years, 7 months ago (2017-04-27 05:32:43 UTC) #1
Benedikt Meurer
lgtm
3 years, 7 months ago (2017-04-27 05:33:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843353002/1
3 years, 7 months ago (2017-04-27 05:33:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843353002/1
3 years, 7 months ago (2017-04-27 07:30:38 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 07:31:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b5de6719da0a9f486ee950dbf68301eaab6...

Powered by Google App Engine
This is Rietveld 408576698