Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2843333004: Add missing .h files to chrome/common/BUILD.gn (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
erikchen
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing .h files to chrome/common/BUILD.gn BUG=661774 Review-Url: https://codereview.chromium.org/2843333004 Cr-Commit-Position: refs/heads/master@{#467842} Committed: https://chromium.googlesource.com/chromium/src/+/5dad32e367d077bf8b84f1700a6cd00e74a20cc1

Patch Set 1 #

Total comments: 2

Patch Set 2 : aitch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/common/BUILD.gn View 1 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Nico
3 years, 7 months ago (2017-04-27 15:56:47 UTC) #3
erikchen
lgtm https://codereview.chromium.org/2843333004/diff/1/chrome/common/BUILD.gn File chrome/common/BUILD.gn (right): https://codereview.chromium.org/2843333004/diff/1/chrome/common/BUILD.gn#newcode71 chrome/common/BUILD.gn:71: "chrome_isolated_world_ids", should this be .h?
3 years, 7 months ago (2017-04-27 15:57:35 UTC) #5
Nico
https://codereview.chromium.org/2843333004/diff/1/chrome/common/BUILD.gn File chrome/common/BUILD.gn (right): https://codereview.chromium.org/2843333004/diff/1/chrome/common/BUILD.gn#newcode71 chrome/common/BUILD.gn:71: "chrome_isolated_world_ids", On 2017/04/27 15:57:35, erikchen wrote: > should this ...
3 years, 7 months ago (2017-04-27 16:04:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843333004/20001
3 years, 7 months ago (2017-04-27 16:04:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/281336)
3 years, 7 months ago (2017-04-27 17:26:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843333004/20001
3 years, 7 months ago (2017-04-27 20:25:51 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 02:14:36 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5dad32e367d077bf8b84f1700a6c...

Powered by Google App Engine
This is Rietveld 408576698