Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 284333002: Revert 270872 "Move all callers of GetHomeDir() to PathService::..." (Closed)

Created:
6 years, 7 months ago by benwells
Modified:
6 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 270872 "Move all callers of GetHomeDir() to PathService::..." > Move all callers of GetHomeDir() to PathService::Get(base::DIR_HOME). > > * Fixes GetHomeDir() for multi-profiles case on Chrome OS. > * Once user signs in on Chrome OS base::DIR_HOME is overridden with primary user homedir. > * Added content switch --homedir to pass that information to ppapi plugins since they run in a separate process and previous base::DIR_HOME override does not apply there. > > This fix doesn't require checking for --multi-profiles switch > since user_id hash is known even without it. > > BUG=331530 > TBR=vitalybuka@chromium.org > > Review URL: https://codereview.chromium.org/200473002 This test has caused two tests to start failing on the chromeos valgrind bots: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%286%29/builds/25884 http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%285%29/builds/26990 TBR=nkostylev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -103 lines) Patch
M trunk/src/base/file_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/base/file_util_posix.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M trunk/src/base/nix/xdg_util.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M trunk/src/chrome/app/chrome_main_delegate.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/login_utils.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M trunk/src/chrome/common/chrome_paths_linux.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/chrome/common/chrome_paths_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/chrome/common/importer/firefox_importer_utils_linux.cc View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/chrome/test/data/extensions/api_test/file_system/open_directory/test.js View 1 chunk +3 lines, -11 lines 0 comments Download
M trunk/src/chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chromeos/chromeos_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/content/ppapi_plugin/ppapi_plugin_main.cc View 2 chunks +1 line, -6 lines 0 comments Download
M trunk/src/crypto/nss_util.cc View 3 chunks +1 line, -4 lines 0 comments Download
M trunk/src/printing/backend/cups_helper.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M trunk/src/remoting/host/branding.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/remoting/host/setup/daemon_controller_delegate_linux.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M trunk/src/rlz/chromeos/lib/rlz_value_store_chromeos.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
benwells
6 years, 7 months ago (2014-05-16 06:32:38 UTC) #1
benwells
6 years, 7 months ago (2014-05-16 06:33:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r270951.

Powered by Google App Engine
This is Rietveld 408576698