Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Side by Side Diff: trunk/src/chrome/common/chrome_paths_unittest.cc

Issue 284333002: Revert 270872 "Move all callers of GetHomeDir() to PathService::..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/chrome_paths_internal.h" 5 #include "chrome/common/chrome_paths_internal.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 8
9 #include "base/base_paths.h"
10 #include "base/file_util.h" 9 #include "base/file_util.h"
11 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
12 #include "base/path_service.h" 11 #include "base/path_service.h"
13 #include "chrome/common/chrome_constants.h" 12 #include "chrome/common/chrome_constants.h"
14 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
15 14
16 // Test the behavior of chrome::GetUserCacheDirectory. 15 // Test the behavior of chrome::GetUserCacheDirectory.
17 // See that function's comments for discussion of the subtleties. 16 // See that function's comments for discussion of the subtleties.
18 TEST(ChromePaths, UserCacheDir) { 17 TEST(ChromePaths, UserCacheDir) {
19 base::FilePath test_profile_dir, cache_dir; 18 base::FilePath test_profile_dir, cache_dir;
20 #if defined(OS_MACOSX) 19 #if defined(OS_MACOSX)
21 ASSERT_TRUE(PathService::Get(base::DIR_APP_DATA, &test_profile_dir)); 20 ASSERT_TRUE(PathService::Get(base::DIR_APP_DATA, &test_profile_dir));
22 test_profile_dir = test_profile_dir.Append("foobar"); 21 test_profile_dir = test_profile_dir.Append("foobar");
23 base::FilePath expected_cache_dir; 22 base::FilePath expected_cache_dir;
24 ASSERT_TRUE(PathService::Get(base::DIR_CACHE, &expected_cache_dir)); 23 ASSERT_TRUE(PathService::Get(base::DIR_CACHE, &expected_cache_dir));
25 expected_cache_dir = expected_cache_dir.Append("foobar"); 24 expected_cache_dir = expected_cache_dir.Append("foobar");
26 #elif(OS_ANDROID) 25 #elif(OS_ANDROID)
27 // No matter what the test_profile_dir is, Android always use the 26 // No matter what the test_profile_dir is, Android always use the
28 // application's cache directory since multiple profiles are not 27 // application's cache directory since multiple profiles are not
29 // supported. 28 // supported.
30 base::FilePath expected_cache_dir; 29 base::FilePath expected_cache_dir;
31 ASSERT_TRUE(PathService::Get(base::DIR_CACHE, &expected_cache_dir)); 30 ASSERT_TRUE(PathService::Get(base::DIR_CACHE, &expected_cache_dir));
32 #elif(OS_POSIX) 31 #elif(OS_POSIX)
33 base::FilePath homedir; 32 base::FilePath homedir = base::GetHomeDir();
34 PathService::Get(base::DIR_HOME, &homedir);
35 // Note: we assume XDG_CACHE_HOME/XDG_CONFIG_HOME are at their 33 // Note: we assume XDG_CACHE_HOME/XDG_CONFIG_HOME are at their
36 // default settings. 34 // default settings.
37 test_profile_dir = homedir.Append(".config/foobar"); 35 test_profile_dir = homedir.Append(".config/foobar");
38 base::FilePath expected_cache_dir = homedir.Append(".cache/foobar"); 36 base::FilePath expected_cache_dir = homedir.Append(".cache/foobar");
39 #endif 37 #endif
40 38
41 // Verify that a profile in the special platform-specific source 39 // Verify that a profile in the special platform-specific source
42 // location ends up in the special target location. 40 // location ends up in the special target location.
43 #if !defined(OS_WIN) // No special behavior on Windows. 41 #if !defined(OS_WIN) // No special behavior on Windows.
44 chrome::GetUserCacheDirectory(test_profile_dir, &cache_dir); 42 chrome::GetUserCacheDirectory(test_profile_dir, &cache_dir);
45 EXPECT_EQ(expected_cache_dir.value(), cache_dir.value()); 43 EXPECT_EQ(expected_cache_dir.value(), cache_dir.value());
46 #endif 44 #endif
47 45
48 // Verify that a profile in some other random directory doesn't use 46 // Verify that a profile in some other random directory doesn't use
49 // the special cache dir. 47 // the special cache dir.
50 test_profile_dir = base::FilePath(FILE_PATH_LITERAL("/some/other/path")); 48 test_profile_dir = base::FilePath(FILE_PATH_LITERAL("/some/other/path"));
51 chrome::GetUserCacheDirectory(test_profile_dir, &cache_dir); 49 chrome::GetUserCacheDirectory(test_profile_dir, &cache_dir);
52 #if defined(OS_ANDROID) 50 #if defined(OS_ANDROID)
53 EXPECT_EQ(expected_cache_dir.value(), cache_dir.value()); 51 EXPECT_EQ(expected_cache_dir.value(), cache_dir.value());
54 #else 52 #else
55 EXPECT_EQ(test_profile_dir.value(), cache_dir.value()); 53 EXPECT_EQ(test_profile_dir.value(), cache_dir.value());
56 #endif 54 #endif
57 } 55 }
OLDNEW
« no previous file with comments | « trunk/src/chrome/common/chrome_paths_linux.cc ('k') | trunk/src/chrome/common/importer/firefox_importer_utils_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698