Switch SupportsUserData uses to use unique_ptr.

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
Review-Url: https://codereview.chromium.org/2843323002
Cr-Commit-Position: refs/heads/master@{#468670}
Committed: https://chromium.googlesource.com/chromium/src/+/778483e30c90f04a1674c1ded8507e226e7db27d

[Avi (use Gerrit), 2017-04-27 04:00:31]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 04:00:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-04-27 04:18:24]

avi@chromium.org changed reviewers:
+ jochen@chromium.org, jsbell@chromium.org

[Avi (use Gerrit), 2017-04-27 04:18:24]

jochen@chromium.org: Please review changes in gin/, ui/
jsbell@chromium.org: Please review changes in storage/

[commit-bot: I haz the power, 2017-04-27 05:19:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 05:19:50]

Dry run: This issue passed the CQ dry run.

[jsbell, 2017-04-27 17:00:12]

lgtm but I'm not an owner so not sure that's useful

https://codereview.chromium.org/2843323002/diff/1/gin/modules/module_registry.cc
File gin/modules/module_registry.cc (right):

https://codereview.chromium.org/2843323002/diff/1/gin/modules/module_registry...
gin/modules/module_registry.cc:141: registry_data = new ModuleRegistryData;
Just to avoid the unowned ptr here, an alternative:

ModuleRegistryData* data = static_cast<ModuleRegistryData*>(
    data->GetUserData(kModuleRegistryKey));
if (data)
  return registry_data->registry.get();

// PerContextData takes ownership of ModuleRegistryData.	 
unique_ptr<ModuleRegistryData> registry_data =
  base::MakeUnique<ModuleRegistryData>();
registry_data->registry.reset(
  new ModuleRegistry(context->GetIsolate()));
ModuleRegistry* registry = registry_data->registry.get();
data->SetUserData(kModuleRegistryKey, std::move(registry_data));
return registry;

... but that's probably harder to read, so whatever you prefer.

[Avi (use Gerrit), 2017-04-27 17:50:28]

jsbell:

You ARE an OWNER in storage/. I hope you are aware of that.

https://codereview.chromium.org/2843323002/diff/1/gin/modules/module_registry.cc
File gin/modules/module_registry.cc (right):

https://codereview.chromium.org/2843323002/diff/1/gin/modules/module_registry...
gin/modules/module_registry.cc:141: registry_data = new ModuleRegistryData;
On 2017/04/27 17:00:11, jsbell wrote:
> Just to avoid the unowned ptr here, an alternative:
> 
> ModuleRegistryData* data = static_cast<ModuleRegistryData*>(
>     data->GetUserData(kModuleRegistryKey));
> if (data)
>   return registry_data->registry.get();
> 
> // PerContextData takes ownership of ModuleRegistryData.	 
> unique_ptr<ModuleRegistryData> registry_data =
>   base::MakeUnique<ModuleRegistryData>();
> registry_data->registry.reset(
>   new ModuleRegistry(context->GetIsolate()));
> ModuleRegistry* registry = registry_data->registry.get();
> data->SetUserData(kModuleRegistryKey, std::move(registry_data));
> return registry;
> 
> ... but that's probably harder to read, so whatever you prefer.

This pattern is all over, so I'm not too worried.

[jsbell, 2017-04-27 17:53:27]

On 2017/04/27 17:50:28, Avi (ping after 24h) wrote:
> You ARE an OWNER in storage/. I hope you are aware of that.

Coffee hadn't kicked in - I misread the j...@ names and target directories. :P

[jochen (gone - plz use gerrit), 2017-05-02 09:19:27]

lgtm

[Avi (use Gerrit), 2017-05-02 15:05:31]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-05-02 15:06:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 16:22:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493737531501630, "parent_rev":
"d9f4dd56083fb4ad41a8bc53bad9a24fa137b6f1", "commit_rev":
"778483e30c90f04a1674c1ded8507e226e7db27d"}

[commit-bot: I haz the power, 2017-05-02 16:22:25]

Description was changed from

==========
Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
==========

to

==========
Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2843323002
Cr-Commit-Position: refs/heads/master@{#468670}
Committed:
https://chromium.googlesource.com/chromium/src/+/778483e30c90f04a1674c1ded850...
==========

[commit-bot: I haz the power, 2017-05-02 16:22:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/778483e30c90f04a1674c1ded850...