Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2843313002: Disable flaky mac test: WidgetObserverTest.ActivationChange (Closed)

Created:
3 years, 7 months ago by Evan Stade
Modified:
3 years, 7 months ago
Reviewers:
alph, sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable test that is flaky on Mac: WidgetObserverTest.ActivationChange This test was previously disabled without comment or explanation on all platforms. It was fixed for non mac platforms but needs to remain disabled on Mac. TBR=sky@chromium.org NOTRY=true BUG=none Review-Url: https://codereview.chromium.org/2843313002 Cr-Commit-Position: refs/heads/master@{#467551} Committed: https://chromium.googlesource.com/chromium/src/+/0acb8f1accf8b3554a10d4f14fb89aa1428909e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M ui/views/widget/widget_unittest.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843313002/1
3 years, 7 months ago (2017-04-27 01:57:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843313002/1
3 years, 7 months ago (2017-04-27 01:58:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843313002/1
3 years, 7 months ago (2017-04-27 02:03:42 UTC) #12
alph
lgtm. thanks!
3 years, 7 months ago (2017-04-27 02:05:37 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 02:12:32 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0acb8f1accf8b3554a10d4f14fb8...

Powered by Google App Engine
This is Rietveld 408576698