Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2843223003: [blink] Skip ancestor clip in PaintLayerPainter for squashed layers. (Closed)

Created:
3 years, 8 months ago by trchen
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[blink] Skip ancestor clip in PaintLayerPainter for squashed layers. The squashing layer passed a differrent painting root that is not the same as the backing's space when painting squashed layers, thus a wrong clip is applied when squashed layers are painted. This was not a problem prior to GeometryMapper-based PaintLayerClipper because the non-GM PaintLayerClipper skipped visual rect optimization in this particular corner case. BUG=712783 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2830013007 Cr-Commit-Position: refs/heads/master@{#467220} (cherry picked from commit fb28c1b7511ceeb4d47ed42dbeb0676591469fe6) Review-Url: https://codereview.chromium.org/2843223003 . Cr-Commit-Position: refs/branch-heads/3071@{#242} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/840427fa341fe9f413fdf5c7df1941f08e152380

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/compositing/squashing/squash-transformed-with-clip.html View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/compositing/squashing/squash-transformed-with-clip-expected.html View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
trchen
3 years, 8 months ago (2017-04-26 23:51:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
840427fa341fe9f413fdf5c7df1941f08e152380.

Powered by Google App Engine
This is Rietveld 408576698