[Home] Use ChromeActivity from init() when creating sheet content

[Home] Use ChromeActivity from init() when creating sheet content

We have several crash reports of NPEs when trying to get the activity
from the current tab while during BottomSheetContent creation. The
current tab currently shouldn't be null when the BottomSheet is opened,
but it's likely that the current tab will soon be null (NTP). Hold on to
a reference to the ChromeActivity passed in to
BottomSheetContentController#init() for use in creating
BottomSheetContents. The BottomSheet is per activity so the activity will
never change.

BUG=711098
Review-Url: https://codereview.chromium.org/2843203002
Cr-Commit-Position: refs/heads/master@{#467507}
Committed: https://chromium.googlesource.com/chromium/src/+/0c5dce88667d9ceeed1d90daa8485aa6c6009176

[Theresa, 2017-04-26 21:47:17]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[Theresa, 2017-04-26 21:47:49]

twellington@chromium.org changed reviewers:
+ mdjones@chromium.org

[Theresa, 2017-04-26 21:47:50]

ptal

[commit-bot: I haz the power, 2017-04-26 21:47:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mdjones, 2017-04-26 22:23:46]

lgtm

[Theresa, 2017-04-26 22:34:32]

The CQ bit was unchecked by twellington@chromium.org

[Theresa, 2017-04-26 22:34:33]

The CQ bit was checked by twellington@chromium.org

[commit-bot: I haz the power, 2017-04-26 22:34:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 23:31:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493246073045990, "parent_rev":
"47926b6e51657d2dc6d10899f00357e06825956a", "commit_rev":
"0c5dce88667d9ceeed1d90daa8485aa6c6009176"}

[commit-bot: I haz the power, 2017-04-26 23:31:12]

Description was changed from

==========
[Home] Use ChromeActivity from init() when creating sheet content

We have several crash reports of NPEs when trying to get the activity
from the current tab while during BottomSheetContent creation. The
current tab currently shouldn't be null when the BottomSheet is opened,
but it's likely that the current tab will soon be null (NTP). Hold on to
a reference to the ChromeActivity passed in to
BottomSheetContentController#init() for use in creating
BottomSheetContents. The BottomSheet is per activity so the activity will
never change.

BUG=711098
==========

to

==========
[Home] Use ChromeActivity from init() when creating sheet content

We have several crash reports of NPEs when trying to get the activity
from the current tab while during BottomSheetContent creation. The
current tab currently shouldn't be null when the BottomSheet is opened,
but it's likely that the current tab will soon be null (NTP). Hold on to
a reference to the ChromeActivity passed in to
BottomSheetContentController#init() for use in creating
BottomSheetContents. The BottomSheet is per activity so the activity will
never change.

BUG=711098

Review-Url: https://codereview.chromium.org/2843203002
Cr-Commit-Position: refs/heads/master@{#467507}
Committed:
https://chromium.googlesource.com/chromium/src/+/0c5dce88667d9ceeed1d90daa848...
==========

[commit-bot: I haz the power, 2017-04-26 23:31:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c5dce88667d9ceeed1d90daa848...