Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2843183002: Add ResetWithReason for AssociatedInterfaceRequest. (Closed)

Created:
3 years, 8 months ago by wangjimmy
Modified:
3 years, 7 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, blink-reviews, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ResetWithReason for AssociatedInterfaceRequest. Add 'pending AssociatedInterfacePtr connection error with reason' test to associated_interface_ptr.html BUG=695635 Review-Url: https://codereview.chromium.org/2843183002 Cr-Commit-Position: refs/heads/master@{#467614} Committed: https://chromium.googlesource.com/chromium/src/+/440629589dbc6ed4fb54dbcc616bca0c06d88632

Patch Set 1 #

Patch Set 2 : Rebase against master. Reupload patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M mojo/public/js/interface_types.js View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/mojo/associated_interface_ptr.html View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
wangjimmy
Hi Yuzhu, PTAL.
3 years, 8 months ago (2017-04-26 21:28:03 UTC) #3
yzshen1
lgtm
3 years, 8 months ago (2017-04-26 23:50:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843183002/20001
3 years, 7 months ago (2017-04-27 07:03:25 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 07:08:41 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/440629589dbc6ed4fb54dbcc616b...

Powered by Google App Engine
This is Rietveld 408576698