Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2843153002:
[subresource_filter] Add browser test verifying cancel behavior (Closed)
|
Created:
3 years, 8 months ago by Charlie Harrison Modified:
3 years, 7 months ago CC:
chromium-reviews, subresource-filter-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[subresource_filter] Add browser test verifying cancel behavior
BUG=637415
Review-Url: https://codereview.chromium.org/2843153002
Cr-Commit-Position: refs/heads/master@{#468010}
Committed: https://chromium.googlesource.com/chromium/src/+/cb5b9c0152349a9b0eb676beb1414a256b52223f
Patch Set 1 #Patch Set 2 : add #include (trybots prev) #
Total comments: 4
Patch Set 3 : engedy review #Patch Set 4 : fix silly typo #Messages
Total messages: 21 (15 generated)
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
csharrison@chromium.org changed reviewers: + engedy@chromium.org, jkarlin@chromium.org
engedy, jkarlin: PTAL. This works because all the relevant activation state for activating subframes is in the throttle manager, which is fully hooked up these days.
LGTM % 2 nits, thanks a lot! https://codereview.chromium.org/2843153002/diff/20001/chrome/browser/subresou... File chrome/browser/subresource_filter/subresource_filter_browsertest.cc (right): https://codereview.chromium.org/2843153002/diff/20001/chrome/browser/subresou... chrome/browser/subresource_filter/subresource_filter_browsertest.cc:718: EXPECT_TRUE(manager.WaitForRequestStart()); nit: ASSERT_TRUE https://codereview.chromium.org/2843153002/diff/20001/chrome/browser/subresou... chrome/browser/subresource_filter/subresource_filter_browsertest.cc:722: EXPECT_FALSE(manager.WaitForResponse()); nit: ASSERT_FALSE
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks! jkarlin would you give final signoff? https://codereview.chromium.org/2843153002/diff/20001/chrome/browser/subresou... File chrome/browser/subresource_filter/subresource_filter_browsertest.cc (right): https://codereview.chromium.org/2843153002/diff/20001/chrome/browser/subresou... chrome/browser/subresource_filter/subresource_filter_browsertest.cc:718: EXPECT_TRUE(manager.WaitForRequestStart()); On 2017/04/27 12:49:32, engedy wrote: > nit: ASSERT_TRUE Done. https://codereview.chromium.org/2843153002/diff/20001/chrome/browser/subresou... chrome/browser/subresource_filter/subresource_filter_browsertest.cc:722: EXPECT_FALSE(manager.WaitForResponse()); On 2017/04/27 12:49:32, engedy wrote: > nit: ASSERT_FALSE Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by csharrison@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from engedy@chromium.org Link to the patchset: https://codereview.chromium.org/2843153002/#ps60001 (title: "fix silly typo")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493390407058520,
"parent_rev": "c5213f9bd6b6e6e95f40852b56ef62f1307c94ee", "commit_rev":
"cb5b9c0152349a9b0eb676beb1414a256b52223f"}
Message was sent while issue was closed.
Description was changed from ========== [subresource_filter] Add browser test verifying cancel behavior BUG=637415 ========== to ========== [subresource_filter] Add browser test verifying cancel behavior BUG=637415 Review-Url: https://codereview.chromium.org/2843153002 Cr-Commit-Position: refs/heads/master@{#468010} Committed: https://chromium.googlesource.com/chromium/src/+/cb5b9c0152349a9b0eb676beb141... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/cb5b9c0152349a9b0eb676beb141... |
