Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 2843053002: [Android] Don't add --tool=asan to junit wrapper scripts. (Closed)

Created:
3 years, 8 months ago by jbudorick
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Don't add --tool=asan to junit wrapper scripts. BUG=715304 Review-Url: https://codereview.chromium.org/2843053002 Cr-Commit-Position: refs/heads/master@{#467494} Committed: https://chromium.googlesource.com/chromium/src/+/a4fc2b93398945ed1953483b6df3ccf433a216bf

Patch Set 1 #

Patch Set 2 : Reverse asan & _device_test check order. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/config/android/internal_rules.gni View 1 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
jbudorick
3 years, 8 months ago (2017-04-26 17:56:35 UTC) #2
mikecase (-- gone --)
lgtm
3 years, 8 months ago (2017-04-26 18:06:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843053002/1
3 years, 8 months ago (2017-04-26 19:08:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/255890)
3 years, 8 months ago (2017-04-26 19:15:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843053002/20001
3 years, 8 months ago (2017-04-26 19:24:46 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 22:55:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a4fc2b93398945ed1953483b6df3...

Powered by Google App Engine
This is Rietveld 408576698