Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2843033002: [test] Increase test coverage for Array constructor inlining. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Increase test coverage for Array constructor inlining. This still doesn't cover all the paths yet, since some paths are impossible to trigger at this point due to the way the CanInlineCall predicate works on the AllocationSite, which says multiple things: - In case of Array(len), the len was always a Smi so far. - In case of Array(...args), storing the args didn't change the elements kind. - In case of Array(len), the len was always less than the initial maximum fast element array size. These conditions are tailored towards Crankshaft and don't really make a lot of sense in the TurboFan world. We'd need more fine grained protections, which we will achieve by refactoring the Array constructor. BUG=chromium:715404, v8:6262 TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2843033002 Cr-Commit-Position: refs/heads/master@{#44901} Committed: https://chromium.googlesource.com/v8/v8/+/23bb8fa9c035191f292826398780267a888b2228

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -0 lines) Patch
A test/mjsunit/compiler/array-constructor.js View 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-26 17:13:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843033002/1
3 years, 8 months ago (2017-04-26 17:14:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/23bb8fa9c035191f292826398780267a888b2228
3 years, 8 months ago (2017-04-26 17:36:40 UTC) #9
Michael Achenbach
3 years, 8 months ago (2017-04-27 07:19:41 UTC) #10
Message was sent while issue was closed.
lgtm, thanks, nice fuzzer inputs :)

Note, that line 821 in
https://storage.googleapis.com/chromium-v8/linux64_gcov_rel/10980eb56e65b9c54...
is still not covered. But I assume that's what you meant in the CL description.

Powered by Google App Engine
This is Rietveld 408576698