Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(35)

Issue 2843013002: Revert of Don't lower priority for scripts inserted by doc.write (Closed)

Created:
2 years, 1 month ago by Pat Meenan
Modified:
2 years, 1 month ago
CC:
chromium-reviews, Yoav Weiss, blink-reviews-html_chromium.org, loading-reviews+parser_chromium.org, loading-reviews_chromium.org, dglazkov+blink, fuzzing_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin, tyoshino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't lower priority for scripts inserted by doc.write (patchset #5 id:70001 of https://codereview.chromium.org/2826213003/ ) Reason for revert: The layout test was broken and racy (http://crbug.com/715528). SHould be trivial to fix (use the same query param for the preloaded and real image) but best to revert, fix and re-land separately. Original issue's description: > Don't lower priority for scripts inserted by doc.write > > HTML Chunks inserted by document.write() are run through a separate > instance of the preload scanner from the main document. If the main > document scanner has already discovered an image then all scripts > discovered by any preload scanner regardless of where they came from > would be considered late-body. > > This behavior causes a regression where a document.write() in the head > that includes multiple script tags will discover them but treat them as > late-body scripts and only load them one at a time. > > BUG=713727, 712338 > > Review-Url: https://codereview.chromium.org/2826213003 > Cr-Commit-Position: refs/heads/master@{#467029} > Committed: https://chromium.googlesource.com/chromium/src/+/1e0d3cbbf60c67ba9856eadcb9e829b3c4bec6c7 TBR=yoav@yoav.ws,kinuko@chromium.org,csharrison@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=713727, 712338 Review-Url: https://codereview.chromium.org/2843013002 Cr-Commit-Position: refs/heads/master@{#467310} Committed: https://chromium.googlesource.com/chromium/src/+/7cf26442aea7fbcf8883717309287e2fc4d64639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -150 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/network/resource-priority.html View 5 chunks +21 lines, -35 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/resource-priority-expected.txt View 1 chunk +6 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector/network/resources/docwrite.js View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 5 chunks +8 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h View 4 chunks +5 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 7 chunks +6 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerFuzzer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/PreloadRequest.h View 3 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/FetchParameters.h View 3 chunks +4 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/FetchParameters.cpp View 4 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Pat Meenan
Created Revert of Don't lower priority for scripts inserted by doc.write
2 years, 1 month ago (2017-04-26 13:22:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843013002/1
2 years, 1 month ago (2017-04-26 13:22:57 UTC) #3
commit-bot: I haz the power
2 years, 1 month ago (2017-04-26 13:23:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7cf26442aea7fbcf888371730928...

Powered by Google App Engine
This is Rietveld 408576698