Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2842983002: [LayoutNG] Paint inlines from the fragment tree

Created:
3 years, 8 months ago by eae
Modified:
3 years, 7 months ago
Reviewers:
CC:
ajuma+watch_chromium.org, atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, fmalita+watch_chromium.org, glebl+reviews_chromium.org, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, ojan+watch_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1, yosin_UTC9
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Paint inlines from the fragment tree Change LayoutNG to not produce LayoutObjects for inlines and instead paint directly from the fragment tree. WIP - DO NOT COMMIT - WIP BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : Add missing NGTextFragmentPainter files #

Patch Set 3 : Rebase w/HEAD #

Patch Set 4 : WIP #

Patch Set 5 : Update #

Patch Set 6 : paint all the things #

Patch Set 7 : Basic box painting support #

Total comments: 3

Patch Set 8 : Rebase w/HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1259 lines, -21 lines) Patch
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_physical_text_fragment.h View 1 2 3 4 5 6 7 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.h View 1 2 3 4 5 6 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc View 1 2 3 4 5 6 7 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h View 1 2 3 4 5 6 5 chunks +18 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxDecorationData.h View 1 2 3 4 5 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxDecorationData.cpp View 1 2 3 4 5 6 2 chunks +17 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/paint/NGBlockFlowPainter.h View 1 2 3 4 5 6 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/paint/NGBlockFlowPainter.cpp View 1 2 3 4 5 6 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/paint/NGBoxFragmentPainter.h View 1 2 3 4 5 6 7 1 chunk +88 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/paint/NGBoxFragmentPainter.cpp View 1 2 3 4 5 6 7 1 chunk +485 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/paint/NGTextFragmentPainter.h View 1 2 3 4 5 6 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/paint/NGTextFragmentPainter.cpp View 1 2 3 4 5 6 1 chunk +279 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/paint/NGTextPainter.h View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/paint/NGTextPainter.cpp View 1 2 3 4 1 chunk +101 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/RoundedInnerRectClipper.h View 1 2 3 4 5 6 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/RoundedInnerRectClipper.cpp View 1 2 3 4 5 6 4 chunks +6 lines, -7 lines 0 comments Download
A third_party/WebKit/ng_paint.html View 1 2 3 4 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (6 generated)
yosin_UTC9
3 years, 7 months ago (2017-05-22 09:14:16 UTC) #3
https://codereview.chromium.org/2842983002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/NGTextPainter.cpp (right):

https://codereview.chromium.org/2842983002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/NGTextPainter.cpp:54: DCHECK(from <=
fragment_paint_info.text.length());
nit: s/DCHECK/DCHECK_LE/

https://codereview.chromium.org/2842983002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/NGTextPainter.cpp:55: DCHECK(to <=
fragment_paint_info.text.length());
nit: s/DCHECK/DCHECK_LE/

It is better to write

DCHECK_LE(to, fragment_paint_info.text.length());
DCHECK_LE(from, to);

https://codereview.chromium.org/2842983002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/NGTextPainter.cpp:65: DCHECK(step ==
kPaintText);
nit: s/DCHECK/DCHECK_EQ/

Powered by Google App Engine
This is Rietveld 408576698