third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp - Issue 2842983002: [LayoutNG] Paint inlines from the fragment tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

Issue 2842983002: [LayoutNG] Paint inlines from the fragment tree

Patch Set: Rebase w/HEAD Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

index 8ad7c16893aa134ac131ba1958df40e5d137931a..ba9f0df586e3360417b9ef531ea28b8ce5b5ed04 100644

--- a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

@@ -67,6 +67,9 @@ static LineLayoutItem EnclosingUnderlineObject(

}

+// TODO(eae): Move

+// Needs offset for root baseline and and logical top for self

+// and furthers position for underline

static int ComputeUnderlineOffsetForUnder(

const ComputedStyle& style,

const InlineTextBox* inline_text_box,