|
|
Created:
3 years, 8 months ago by Michael Achenbach Modified:
3 years, 7 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionPartial revert of "Attempt to disable tab_capture_end2end_tests on the trybots"
This partially reverts:
https://codereview.chromium.org/2828143007
to fix broken GPU Linux builder.
BUG=714976, 714336
TBR=dpranke@chromium.org
NOTRY=true
Review-Url: https://codereview.chromium.org/2842963003
Cr-Commit-Position: refs/heads/master@{#467318}
Committed: https://chromium.googlesource.com/chromium/src/+/b8d34ab3bfbbc9cd34d48a72bad3fdb0ea5507b4
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
Description was changed from ========== Partial revert of "Attempt to disable tab_capture_end2end_tests on the trybots" This is to fix broken GPU Linux builder. BUG=714976,714336 ========== to ========== Partial revert of "Attempt to disable tab_capture_end2end_tests on the trybots" This is to fix broken GPU Linux builder. BUG=714976,714336 TBR=dpranke@chromium.org ==========
machenbach@chromium.org changed reviewers: + dpranke@chromium.org, emso@chromium.org, phajdan.jr@chromium.org
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL, +current troopers.
Description was changed from ========== Partial revert of "Attempt to disable tab_capture_end2end_tests on the trybots" This is to fix broken GPU Linux builder. BUG=714976,714336 TBR=dpranke@chromium.org ========== to ========== Partial revert of "Attempt to disable tab_capture_end2end_tests on the trybots" This partially reverts: https://codereview.chromium.org/2828143007 to fix broken GPU Linux builder. BUG=714976,714336 TBR=dpranke@chromium.org ==========
Since the incremental build seems broken, we might even be able to revert this change again, after it fixes the linux builder. We should just not clobber it anymore :)
Since the incremental build seems broken, we might even be able to revert this change again, after it fixes the linux builder. We should just not clobber it anymore :)
lgtm
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
linux_android_rel_ng is quite flaky ATM. If all is green and that's the only one left I'll add NOTRY
Description was changed from ========== Partial revert of "Attempt to disable tab_capture_end2end_tests on the trybots" This partially reverts: https://codereview.chromium.org/2828143007 to fix broken GPU Linux builder. BUG=714976,714336 TBR=dpranke@chromium.org ========== to ========== Partial revert of "Attempt to disable tab_capture_end2end_tests on the trybots" This partially reverts: https://codereview.chromium.org/2828143007 to fix broken GPU Linux builder. BUG=714976,714336 TBR=dpranke@chromium.org NOTRY=true ==========
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1493215571840500, "parent_rev": "787749bab4ca1dde70b58a9f85aa96577125f674", "commit_rev": "b8d34ab3bfbbc9cd34d48a72bad3fdb0ea5507b4"}
Message was sent while issue was closed.
Description was changed from ========== Partial revert of "Attempt to disable tab_capture_end2end_tests on the trybots" This partially reverts: https://codereview.chromium.org/2828143007 to fix broken GPU Linux builder. BUG=714976,714336 TBR=dpranke@chromium.org NOTRY=true ========== to ========== Partial revert of "Attempt to disable tab_capture_end2end_tests on the trybots" This partially reverts: https://codereview.chromium.org/2828143007 to fix broken GPU Linux builder. BUG=714976,714336 TBR=dpranke@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2842963003 Cr-Commit-Position: refs/heads/master@{#467318} Committed: https://chromium.googlesource.com/chromium/src/+/b8d34ab3bfbbc9cd34d48a72bad3... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b8d34ab3bfbbc9cd34d48a72bad3... |