Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 2842963003: Partial revert of "Attempt to disable tab_capture_end2end_tests on the trybots" (Closed)

Created:
2 years, 4 months ago by Michael Achenbach
Modified:
2 years, 4 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Partial revert of "Attempt to disable tab_capture_end2end_tests on the trybots" This partially reverts: https://codereview.chromium.org/2828143007 to fix broken GPU Linux builder. BUG=714976, 714336 TBR=dpranke@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2842963003 Cr-Commit-Position: refs/heads/master@{#467318} Committed: https://chromium.googlesource.com/chromium/src/+/b8d34ab3bfbbc9cd34d48a72bad3fdb0ea5507b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
Michael Achenbach
PTAL, +current troopers.
2 years, 4 months ago (2017-04-26 13:15:01 UTC) #5
Michael Achenbach
Since the incremental build seems broken, we might even be able to revert this change ...
2 years, 4 months ago (2017-04-26 13:18:09 UTC) #7
Michael Achenbach
Since the incremental build seems broken, we might even be able to revert this change ...
2 years, 4 months ago (2017-04-26 13:18:09 UTC) #8
emso
lgtm
2 years, 4 months ago (2017-04-26 13:20:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842963003/1
2 years, 4 months ago (2017-04-26 13:21:20 UTC) #12
Michael Achenbach
linux_android_rel_ng is quite flaky ATM. If all is green and that's the only one left ...
2 years, 4 months ago (2017-04-26 13:56:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842963003/1
2 years, 4 months ago (2017-04-26 14:06:38 UTC) #17
commit-bot: I haz the power
2 years, 4 months ago (2017-04-26 14:11:06 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b8d34ab3bfbbc9cd34d48a72bad3...

Powered by Google App Engine
This is Rietveld 408576698