CSS Motion Path: delete implementation of offset-rotation property

CSS Motion Path: delete implementation of offset-rotation property

The 'offset-rotation' property has been replaced by 'offset-rotate'.

'offset-rotation' is among the properties disabled in M58.

The runtime flag to conditionally enable 'offset-rotate' is also
being retired, as offset-rotate has shipped.

Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/FgU5o52yBAAJ

BUG=711937
Review-Url: https://codereview.chromium.org/2842933003
Cr-Commit-Position: refs/heads/master@{#468258}
Committed: https://chromium.googlesource.com/chromium/src/+/25825f60c805cf300a29b915b5f16cb508afecf9

[Eric Willigers, 2017-04-27 07:52:45]

ericwilligers@chromium.org changed reviewers:
+ bugsnash@chromium.org

[Bugs Nash, 2017-04-27 23:28:37]

On 2017/04/27 at 07:52:45, ericwilligers wrote:
> 

lgtm with comment update. Nice work changing all the variable names too :)

[Bugs Nash, 2017-04-27 23:28:48]

https://codereview.chromium.org/2842933003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/2842933003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:749: // offset:
<offset-path> <offset-distance> <offset-rotation>
update comment

[Eric Willigers, 2017-04-28 01:23:39]

ericwilligers@chromium.org changed reviewers:
+ meade@chromium.org

[Eric Willigers, 2017-04-28 01:23:40]

This is the 4th of 5 patches for properties retired in M58.

https://codereview.chromium.org/2842933003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/2842933003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:749: // offset:
<offset-path> <offset-distance> <offset-rotation>
On 2017/04/27 23:28:48, Bugs Nash wrote:
> update comment

Done.

[meade_UTC10, 2017-04-28 07:47:37]

lgtm

[Eric Willigers, 2017-04-28 10:26:40]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 10:26:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 12:22:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 12:22:49]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Eric Willigers, 2017-04-28 20:27:16]

ericwilligers@chromium.org changed reviewers:
+ rbyers@chromium.org

[Eric Willigers, 2017-04-28 20:27:16]

+rbyers for computed-style-listing-expected.txt OWNER

[Eric Willigers, 2017-04-28 20:32:44]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 20:33:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 23:08:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 23:08:06]

Dry run: This issue passed the CQ dry run.

[Rick Byers, 2017-04-29 02:28:10]

On 2017/04/28 20:27:16, Eric Willigers wrote:
> +rbyers for computed-style-listing-expected.txt OWNER

virtual/stable/webexposed LGTM

For the record please add a link to the intent thread in the CL description.

[Eric Willigers, 2017-04-30 21:30:14]

Description was changed from

==========
CSS Motion Path: delete implementation of offset-rotation property

The 'offset-rotation' property has been replaced by 'offset-rotate'.

'offset-rotation' is among the properties disabled in M58.

The runtime flag to conditionally enable 'offset-rotate' is also
being retired, as offset-rotate has shipped.

BUG=711937
==========

to

==========
CSS Motion Path: delete implementation of offset-rotation property

The 'offset-rotation' property has been replaced by 'offset-rotate'.

'offset-rotation' is among the properties disabled in M58.

The runtime flag to conditionally enable 'offset-rotate' is also
being retired, as offset-rotate has shipped.

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/FgU5o52y...

BUG=711937
==========

[Eric Willigers, 2017-04-30 21:30:22]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2017-04-30 21:30:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org, meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2842933003/#ps60001
(title: "remove offsetRotation from webexposed")

[commit-bot: I haz the power, 2017-04-30 21:30:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-30 23:18:32]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493587822807920,
"parent_rev": "2a7adc3543e9b9b0bf44563830a3502ceba76650", "commit_rev":
"25825f60c805cf300a29b915b5f16cb508afecf9"}

[commit-bot: I haz the power, 2017-04-30 23:18:43]

Description was changed from

==========
CSS Motion Path: delete implementation of offset-rotation property

The 'offset-rotation' property has been replaced by 'offset-rotate'.

'offset-rotation' is among the properties disabled in M58.

The runtime flag to conditionally enable 'offset-rotate' is also
being retired, as offset-rotate has shipped.

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/FgU5o52y...

BUG=711937
==========

to

==========
CSS Motion Path: delete implementation of offset-rotation property

The 'offset-rotation' property has been replaced by 'offset-rotate'.

'offset-rotation' is among the properties disabled in M58.

The runtime flag to conditionally enable 'offset-rotate' is also
being retired, as offset-rotate has shipped.

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/FgU5o52y...

BUG=711937

Review-Url: https://codereview.chromium.org/2842933003
Cr-Commit-Position: refs/heads/master@{#468258}
Committed:
https://chromium.googlesource.com/chromium/src/+/25825f60c805cf300a29b915b5f1...
==========

[commit-bot: I haz the power, 2017-04-30 23:18:44]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/25825f60c805cf300a29b915b5f1...