Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2842933002: De-duplicate create element code paths in the HTML parser. (Closed)

Created:
2 years, 4 months ago by dominicc (has gone to gerrit)
Modified:
2 years, 4 months ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

De-duplicate create element code paths in the HTML parser. The HTMLElementFactory used to take the form element pointer for form association. That operation happens as a discrete step now for customized built-in elements. Now that HTMLElementFactory doesn't do form association any more, HTML and non-HTML element construction can be merged together the way they are in the specs. BUG=648828 Review-Url: https://codereview.chromium.org/2842933002 Cr-Commit-Position: refs/heads/master@{#467272} Committed: https://chromium.googlesource.com/chromium/src/+/0152a0cddd258abfafefdcf14da540acb04a729b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -48 lines) Patch
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp View 10 chunks +64 lines, -47 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
dominicc (has gone to gerrit)
PTAL
2 years, 4 months ago (2017-04-26 03:14:45 UTC) #2
kouhei (in TOK)
lgtm % test pass https://codereview.chromium.org/2842933002/diff/1/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp File third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp (right): https://codereview.chromium.org/2842933002/diff/1/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp#newcode946 third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp:946: // something useful with parse ...
2 years, 4 months ago (2017-04-26 04:24:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842933002/1
2 years, 4 months ago (2017-04-26 08:52:19 UTC) #9
commit-bot: I haz the power
2 years, 4 months ago (2017-04-26 08:55:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0152a0cddd258abfafefdcf14da5...

Powered by Google App Engine
This is Rietveld 408576698