Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: src/inspector/v8-debugger.cc

Issue 2842903002: [inspector] improved V8Debugger::breakProgram method (Closed)
Patch Set: rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-debugger.h ('k') | src/inspector/v8-debugger-agent-impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-debugger.cc
diff --git a/src/inspector/v8-debugger.cc b/src/inspector/v8-debugger.cc
index e5e4dda5bfddefec49b837cb8169cd8b2fe894d1..cd55c877ae42e19f5136814eae14222d337b83f8 100644
--- a/src/inspector/v8-debugger.cc
+++ b/src/inspector/v8-debugger.cc
@@ -354,11 +354,14 @@ bool V8Debugger::canBreakProgram() {
return !v8::debug::AllFramesOnStackAreBlackboxed(m_isolate);
}
-void V8Debugger::breakProgram() {
+bool V8Debugger::breakProgram(int targetContextGroupId) {
// Don't allow nested breaks.
- if (isPaused()) return;
- if (!canBreakProgram()) return;
+ if (isPaused()) return true;
+ if (!canBreakProgram()) return true;
+ DCHECK(targetContextGroupId);
+ m_targetContextGroupId = targetContextGroupId;
v8::debug::BreakRightNow(m_isolate);
+ return m_inspector->enabledDebuggerAgentForGroup(targetContextGroupId);
}
void V8Debugger::continueProgram(int targetContextGroupId) {
« no previous file with comments | « src/inspector/v8-debugger.h ('k') | src/inspector/v8-debugger-agent-impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698