Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 2842883002: Change QuicStreamFactory::active_jobs_ to a Map from QuicServerId to Job (Closed)

Created:
3 years, 8 months ago by Zhongyi Shi
Modified:
3 years, 8 months ago
Reviewers:
Ryan Hamilton, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, eroman, mmenke, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change QuicStreamFactory::active_jobs_ to a Map from QuicServerId to Job as auxiliary Job is no longer supported. There should be at most one Job serving the same QuicServerId. BUG=707953 Review-Url: https://codereview.chromium.org/2842883002 Cr-Commit-Position: refs/heads/master@{#467380} Committed: https://chromium.googlesource.com/chromium/src/+/bc11943ed50cef962cc059b6e24493f84c4de5fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -45 lines) Patch
M net/log/net_log_event_type_list.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 4 chunks +8 lines, -31 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_peer.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Zhongyi Shi
3 years, 8 months ago (2017-04-25 20:51:51 UTC) #3
Ryan Hamilton
lgtm Nice!
3 years, 8 months ago (2017-04-25 21:37:53 UTC) #7
xunjieli
This is great. LGTM. Thanks, Cherie!
3 years, 8 months ago (2017-04-26 14:00:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842883002/1
3 years, 8 months ago (2017-04-26 17:10:23 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 18:05:34 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc11943ed50cef962cc059b6e244...

Powered by Google App Engine
This is Rietveld 408576698