Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 2842843004: Update postmortem metadata generator. (Closed)

Created:
3 years, 8 months ago by noordhuis
Modified:
3 years, 8 months ago
Reviewers:
Yang, Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Update postmortem metadata generator. Add PropertyDetails::AttributesField + PropertyDetails::LocationField. Review-Url: https://codereview.chromium.org/2842843004 Cr-Commit-Position: refs/heads/master@{#44889} Committed: https://chromium.googlesource.com/v8/v8/+/bfae9db9d1bc1a20fa28ab0a61a15e1dc13aeff9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M tools/gen-postmortem-metadata.py View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
noordhuis
3 years, 8 months ago (2017-04-26 10:52:23 UTC) #2
Michael Achenbach
lgtm - rubberstamp
3 years, 8 months ago (2017-04-26 10:53:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842843004/1
3 years, 8 months ago (2017-04-26 11:55:44 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 12:24:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/bfae9db9d1bc1a20fa28ab0a61a15e1dc13...

Powered by Google App Engine
This is Rietveld 408576698