Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2842823002: chrome/android: Consume down events for mouse drag gesture. (Closed)

Created:
3 years, 8 months ago by Khushal
Modified:
3 years, 7 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, mustaq
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/android: Consume down events for mouse drag gesture. Mouse drag gestures on android are delivered using a stream of ACTION_MOVE events. If the view does not consume the ACTION_DOWN event that starts the gesture, it will not receive the following move events. Consume this event in the EventForwarder to ensure the ContentView gets the complete gesture. BUG=714845 Review-Url: https://codereview.chromium.org/2842823002 Cr-Commit-Position: refs/heads/master@{#467780} Committed: https://chromium.googlesource.com/chromium/src/+/6bc101ebf27a7a56f28d5264aed265ec43a8db45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/android/java/src/org/chromium/ui/base/EventForwarder.java View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Khushal
This fixes the drag by basically restoring the behaviour the EventHandler was providing. Also, I ...
3 years, 8 months ago (2017-04-25 21:30:11 UTC) #2
aelias_OOO_until_Jul13
Looks OK, but let me know if you find a way to make it work ...
3 years, 8 months ago (2017-04-26 00:35:54 UTC) #3
aelias_OOO_until_Jul13
Hmm, we're short of ideas for how to actually make it work for WebView for ...
3 years, 8 months ago (2017-04-26 23:57:54 UTC) #7
Khushal
On 2017/04/26 23:57:54, aelias wrote: > Hmm, we're short of ideas for how to actually ...
3 years, 7 months ago (2017-04-27 18:59:27 UTC) #10
David Trainor- moved to gerrit
lgtm
3 years, 7 months ago (2017-04-27 19:19:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842823002/1
3 years, 7 months ago (2017-04-27 19:32:52 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 20:46:16 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6bc101ebf27a7a56f28d5264aed2...

Powered by Google App Engine
This is Rietveld 408576698