Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2842813002: Correct security critical bit for third_party/ced (Closed)

Created:
3 years, 7 months ago by Oliver Chang
Modified:
3 years, 7 months ago
CC:
chromium-reviews, Martin Barbella
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct security critical bit for third_party/ced This library is shipped, so should be marked as "Security Critical". R=jinsukkim@chromium.org,jshin@chromium.org Review-Url: https://codereview.chromium.org/2842813002 Cr-Commit-Position: refs/heads/master@{#467155} Committed: https://chromium.googlesource.com/chromium/src/+/c2f72fc86077822222610a0ed35ef068a010733a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/ced/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Oliver Chang
PTAL, thanks!
3 years, 7 months ago (2017-04-25 17:57:39 UTC) #2
Jinsuk Kim
On 2017/04/25 17:57:39, Oliver Chang wrote: > PTAL, thanks! Thanks for the change. Would you ...
3 years, 7 months ago (2017-04-25 22:20:05 UTC) #3
Oliver Chang
On 2017/04/25 22:20:05, Jinsuk Kim wrote: > On 2017/04/25 17:57:39, Oliver Chang wrote: > > ...
3 years, 7 months ago (2017-04-25 22:39:24 UTC) #4
Jinsuk Kim
On 2017/04/25 22:39:24, Oliver Chang wrote: > On 2017/04/25 22:20:05, Jinsuk Kim wrote: > > ...
3 years, 7 months ago (2017-04-25 22:45:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842813002/1
3 years, 7 months ago (2017-04-25 22:46:24 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-04-25 23:00:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c2f72fc86077822222610a0ed35e...

Powered by Google App Engine
This is Rietveld 408576698